Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge integration to Main #1676

Merged
merged 47 commits into from
Sep 27, 2023
Merged
Changes from 1 commit
Commits
Show all changes
47 commits
Select commit Hold shift + click to select a range
7679af3
Revert "maint(core): upgrade lucene to 9.7.0 (#1617)" (#1622)
alextheimer Jul 11, 2023
80245ce
feat(core): Simplify configuration to scale Filodb horizontally (#1610)
vishramachandran Jul 12, 2023
90303aa
filodb(core) add debugging info for empty histogram. (#1613)
yu-shipit Jul 13, 2023
5b05779
fix(core) make the error message more frendly to users. (#1593)
yu-shipit Jul 13, 2023
a93666d
Revert "filodb(core) add debugging info for empty histogram. (#1613)"…
yu-shipit Jul 13, 2023
a37bf5f
Adding logging statement when warning is produced. (#1625)
kvpetrov Jul 14, 2023
8ecf630
perf(query): Remove boxed Double allocations from NaN checks during d…
vishramachandran Jul 17, 2023
f14a13c
fix(core) make the error message more frendly to users. (#1593) (#1630)
yu-shipit Jul 17, 2023
6ac0255
fix nullpointer happened in cardinality busting job. (#1631)
yu-shipit Jul 18, 2023
b9ea680
filodb(core) add debugging info for empty histogram. (#1624)
yu-shipit Jul 18, 2023
eebd5f4
fix(query): prevent list.head on empty list (#1632)
alextheimer Jul 20, 2023
6c1693a
maint(kafka): update consumer client id (#1633)
alextheimer Jul 24, 2023
5dadfb9
fix(query): prevent list.head on empty list (#1632)
alextheimer Jul 20, 2023
8929fb2
Merge pull request #1634 from alextheimer/cherry-pick
amolnayak311 Jul 24, 2023
59cae2a
fix(core): Consolidate num-nodes duplicate config (#1635)
vishramachandran Jul 24, 2023
ea1644b
Fix memory alloc config (#1638)
vishramachandran Jul 24, 2023
955814e
fix(query) Regex equals .* must ignore the label and match series eve…
amolnayak311 Jul 28, 2023
f5018ae
fix(core) fix the binary join aggregation across different partitions…
yu-shipit Jul 31, 2023
84a185f
feat(query): Cardinality V2 API Query Plan changes (#1637)
sandeep6189 Aug 2, 2023
c7e26a9
fix(query) Fix regression with regex match (#1640)
amolnayak311 Aug 4, 2023
dd59325
fix(query) support unary operators(+/-) (#1642)
yu-shipit Aug 4, 2023
d84c6c8
fix(core): Bug in calculating size of SerializedRangeVector (#1643)
vishramachandran Aug 9, 2023
38c682c
perf(core): ~Two times throughput improvement for Lucene queries with…
vishramachandran Aug 9, 2023
f3352e2
cherry-pick histogram debugging message and cardinality job nullptr f…
yu-shipit Aug 15, 2023
bfbeb36
filodb(core) add debugging info for empty histogram. (#1613) (#1649)
yu-shipit Aug 15, 2023
523999c
feat(query): Cardinality V2 API Query Plan changes (#1637)
sandeep6189 Aug 2, 2023
9ed8685
Merge pull request #1650 from amolnayak311/integration
amolnayak311 Aug 16, 2023
594ffce
fix(query): Adding user datasets for Cardinality V2 RemoteMetadataExe…
sandeep6189 Aug 17, 2023
89bd678
Fix MultiPartition Card Queries (#1652)
sandeep6189 Aug 18, 2023
bdcfde7
fix(query): Adding user datasets for Cardinality V2 RemoteMetadataExe…
sandeep6189 Aug 17, 2023
17fb077
Fix MultiPartition Card Queries (#1652)
sandeep6189 Aug 18, 2023
225617c
Merge pull request #1654 from sandeep6189/integration
amolnayak311 Aug 18, 2023
89095e2
feat(core): Add Query CPU Time for Index Lookups (#1655)
vishramachandran Aug 21, 2023
1e56ef9
fix(metering): Overriding the cluster name .passed to SingleClusterPl…
sandeep6189 Aug 23, 2023
c77a95a
fix(metering): Overriding the cluster name .passed to SingleClusterPl…
sandeep6189 Aug 23, 2023
710c3d2
misc(core): add downsample support for aggregated data (#1661)
sherali42 Aug 25, 2023
df3922d
misc(core): add downsample support for aggregated data (#1661)
sherali42 Aug 25, 2023
14115cf
cherry-pic misc(core): add downsample support for aggregated data (#1…
sherali42 Aug 30, 2023
6cb5433
maint(core): upgrade to Lucene 9.7.0 (#1662)
alextheimer Aug 30, 2023
7adc382
bug(query): Streaming query execution allocated too much mem via RB (…
vishramachandran Sep 1, 2023
bf8ead0
perf(card): Adding config support for DS card flushCount and perf log…
sandeep6189 Sep 11, 2023
50d28ea
fix(core) fix the binary join aggregation across different partitions…
yu-shipit Sep 13, 2023
f7d60ac
Merge branch 'develop' into integration
Sep 19, 2023
ba0023f
Merge pull request #1673 from yu-shipit/integration
yu-shipit Sep 19, 2023
78a33f6
Bump filodb version to 0.9.23.
Sep 19, 2023
b5a2e40
Merge pull request #1674 from yu-shipit/integration
yu-shipit Sep 19, 2023
4e97f53
Merge branch 'integration'
Sep 27, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix(query): prevent list.head on empty list (#1632)
alextheimer committed Jul 24, 2023
commit 5dadfb939512972bca602d7101c07b34790b3279
Original file line number Diff line number Diff line change
@@ -423,6 +423,9 @@ object LogicalPlanUtils extends StrictLogging {
LogicalPlanUtils.getTargetSchemaIfUnchanging(targetSchemaProvider, filters, interval)
}
}
if (rsTschemaOpts.isEmpty) {
return None
}
// make sure all tschemas are defined, and they all match
val referenceSchema = rsTschemaOpts.head
if (referenceSchema.isDefined
Original file line number Diff line number Diff line change
@@ -3366,4 +3366,34 @@ class PlannerHierarchySpec extends AnyFunSpec with Matchers with PlanValidationS
validatePlan(ep, test.expected, sort = true)
}
}

it("should generate correct plan for aggregations/joins without selectors") {
val queryExpectedPairs = Seq(
// FIXME: this first plan is needlessly complex (but will return the correct result)
("""sum(vector(123)) by(foo)""",
"""E~StitchRvsExec() on InProcessPlanDispatcher
|-T~AggregatePresenter(aggrOp=Sum, aggrParams=List(), rangeParams=RangeParams(1634172830,300,1634777330))
|--E~LocalPartitionReduceAggregateExec(aggrOp=Sum, aggrParams=List()) on InProcessPlanDispatcher
|---T~AggregateMapReduce(aggrOp=Sum, aggrParams=List(), without=List(), by=List(foo))
|----T~VectorFunctionMapper(funcParams=List())
|-----E~ScalarFixedDoubleExec(params = RangeParams(1634172830,300,1634777330), value = 123.0) on InProcessPlanDispatcher
|-T~AggregatePresenter(aggrOp=Sum, aggrParams=List(), rangeParams=RangeParams(1633913330,300,1634172530))
|--E~LocalPartitionReduceAggregateExec(aggrOp=Sum, aggrParams=List()) on InProcessPlanDispatcher
|---T~AggregateMapReduce(aggrOp=Sum, aggrParams=List(), without=List(), by=List(foo))
|----T~VectorFunctionMapper(funcParams=List())
|-----E~ScalarFixedDoubleExec(params = RangeParams(1633913330,300,1634172530), value = 123.0) on InProcessPlanDispatcher""".stripMargin),
("""vector(123) + on(foo) vector(123)""",
"""E~BinaryJoinExec(binaryOp=ADD, on=List(foo), ignoring=List()) on InProcessPlanDispatcher
|-T~VectorFunctionMapper(funcParams=List())
|--E~ScalarFixedDoubleExec(params = RangeParams(1633913330,300,1634777330), value = 123.0) on InProcessPlanDispatcher
|-T~VectorFunctionMapper(funcParams=List())
|--E~ScalarFixedDoubleExec(params = RangeParams(1633913330,300,1634777330), value = 123.0) on InProcessPlanDispatcher""".stripMargin),
)
val timeParams = TimeStepParams(startSeconds, step, endSeconds)
for ((query, expected) <- queryExpectedPairs) {
val lp = Parser.queryRangeToLogicalPlan(query, timeParams, Antlr)
val execPlan = rootPlanner.materialize(lp, QueryContext(origQueryParams = queryParams))
validatePlan(execPlan, expected)
}
}
}