misc(query): limit partKey/partId lookup results early #1692
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
previously approved these changes
Dec 7, 2023
core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala
Outdated
Show resolved
Hide resolved
sandeep6189
previously approved these changes
Dec 7, 2023
There was a problem hiding this comment.
Thanks a bunch @sherali42 @amolnayak311 . This will definitely help protect the system with runaway queries
core/src/test/scala/filodb.core/memstore/PartKeyLuceneIndexSpec.scala
Outdated
Show resolved
Hide resolved
core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala
Outdated
Show resolved
Hide resolved
sandeep6189
previously approved these changes
Dec 7, 2023
amolnayak311
requested changes
Dec 7, 2023
core/src/main/scala/filodb.core/memstore/PartKeyLuceneIndex.scala
Outdated
Show resolved
Hide resolved
amolnayak311
approved these changes
Dec 8, 2023
There was a problem hiding this comment.
LGTM, left a couple of comments. Thanks for the PR @sherali42
sherali42
added a commit
to sherali42/FiloDB
that referenced
this pull request
Dec 9, 2023
sherali42
added a commit
that referenced
this pull request
Dec 9, 2023
| @@ -901,8 +901,9 @@ class PartKeyLuceneIndex(ref: DatasetRef, | |||
| //scalastyle:on method.length | |||
| def partIdsFromFilters(columnFilters: Seq[ColumnFilter], | |||
| startTime: Long, | |||
| endTime: Long): debox.Buffer[Int] = { | |||
| val collector = new PartIdCollector() // passing zero for unlimited results | |||
| endTime: Long, | |||
There was a problem hiding this comment.
Can you remove the limit from this and all the partId collectors ? This specific method is used in regular PromQL queries and it should not silently limit. The data could be aggregated
There was a problem hiding this comment.
Never mind - the default value for that param I see is Int.MaxValue, and PromQL API path is not passing in any value.
sherali42
added a commit
to sherali42/FiloDB
that referenced
this pull request
Dec 11, 2023
sherali42
added a commit
that referenced
this pull request
Dec 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
The commit(s) message(s) follows the contribution guidelines ?
Tests for the changes have been added (for bug fixes / features) ?
Stop collecting results once limit is hit. This will avoid unnecessary cpu cycles and heap usage