Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(cardinality): Deprecating CardinalityV1 and simplifying the cardinality logical and exec plans #1703

Merged
merged 1 commit into from
Feb 1, 2024

Conversation

sandeep6189
Copy link
Contributor

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

New behavior : simplifying the codebase by removing the v1 cardinality code.

BREAKING CHANGES

Breaking changes may include:

  • Deprecating V1 TsCardinalities and removing its helper functions.

Sorry, something went wrong.

@sandeep6189 sandeep6189 changed the title fix(cardinality): Cleaning up cardinality v1 api code fix(cardinality): Deprecating CardinalityV1 and simplifying the cardinality code flow Jan 24, 2024
@sandeep6189 sandeep6189 changed the title fix(cardinality): Deprecating CardinalityV1 and simplifying the cardinality code flow fix(cardinality): Deprecating CardinalityV1 and simplifying the cardinality logical and exec plans Jan 24, 2024
Copy link
Contributor

@alextheimer alextheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a ton for staying on top of this @sandeep6189 🙏

@sandeep6189 sandeep6189 merged commit 63e7dfb into filodb:develop Feb 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants