Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

misc(sparkjobs): publish additional metric with no tags for successful completion #1711

Merged
merged 1 commit into from
Feb 29, 2024
Merged

misc(sparkjobs): publish additional metric with no tags for successful completion #1711

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spark-jobs/src/main/scala/filodb/downsampler/chunk/DownsamplerMain.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,9 @@ class Downsampler(settings: DownsamplerSettings) extends Serializable {
s"$downsamplePeriodStr")
val jobCompleted = Kamon.counter("chunk-migration-completed")
.withTag("downsamplePeriod", downsamplePeriodStr)
val jobCompletedNoTags = Kamon.counter("chunk-migration-completed-success").withoutTags()
jobCompleted.increment()
jobCompletedNoTags.increment()
val downsampleHourStartGauge = Kamon.gauge("chunk-downsampler-period-start-hour")
.withTag("downsamplePeriod", downsamplePeriodStr)
downsampleHourStartGauge.update(userTimeStart / 1000 / 60 / 60)
Expand Down
2 changes: 2 additions & 0 deletions spark-jobs/src/main/scala/filodb/downsampler/index/DSIndexJobMain.scala
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,9 @@ class IndexJobDriver(dsSettings: DownsamplerSettings, dsIndexJobSettings: DSInde
DownsamplerContext.dsLogger.info(s"Index Downsampling Driver completed successfully for downsample period " +
s"$downsamplePeriodStr doFullMigration=$doFullMigration")
val jobCompleted = Kamon.counter("index-migration-completed").withTag("downsamplePeriod", downsamplePeriodStr)
val jobCompletedNoTags = Kamon.counter("index-migration-completed-success").withoutTags()
jobCompleted.increment()
jobCompletedNoTags.increment()

if (!doFullMigration) {
val downsampleHourStartGauge = Kamon.gauge("index-downsampler-period-start-hour")
Expand Down
Loading