Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(histogram): Adding support for min max for prom and delta histograms #1712

Merged
merged 8 commits into from
Feb 20, 2024
Merged

feat(histogram): Adding support for min max for prom and delta histograms #1712

merged 8 commits into from
Feb 20, 2024

Conversation

sandeep6189
Copy link
Contributor

@sandeep6189 sandeep6189 commented Feb 9, 2024 •
edited
Loading

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

New behavior : Adding support for min max for prom and delta histograms

@sandeep6189 sandeep6189 requested a review from sherali42 February 9, 2024 16:37
sherali42
sherali42 approved these changes Feb 20, 2024
View reviewed changes
Copy link
Contributor

@sherali42 sherali42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @sandeep6189 for adding support for min/max histograms

@sandeep6189 sandeep6189 merged commit feb8a6e into filodb:develop Feb 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amolnayak311 amolnayak311 amolnayak311 left review comments

@sherali42 sherali42 sherali42 approved these changes

@alextheimer alextheimer Awaiting requested review from alextheimer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sandeep6189 @amolnayak311 @sherali42