fix(query): histogram queries with PeriodSeriesWithWindowing logical plan don't apply le label filter #1715
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep6189
changed the title
amolnayak311
requested changes
Feb 15, 2024
coordinator/src/main/scala/filodb.coordinator/queryplanner/SingleClusterPlanner.scala
Outdated
Show resolved
Hide resolved
coordinator/src/test/scala/filodb.coordinator/queryplanner/SingleClusterPlannerSpec.scala
Show resolved
Hide resolved
sandeep6189
force-pushed
the
le_label_query_fix
branch
from
ef0f7e8 to
88ddab9
Compare
amolnayak311
approved these changes
Feb 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : Histogram bucket queries with PeriodSeriesWithWindowing logical plan (queries such as sum(rate) etc. use this logical plan) don't apply the InstantVectorFunctionMapper transformer correctly for le label filter.
New behavior : Adding the required transformer to correctly pick up the required bucket given in the query.