fix(query): ShardKeyRegexPlanner batching fix #1716
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Plans are materialized directly by inner planners when they draw data from one partition. However, when the ShardKeyRegexPlanner fanout batch size is small enough, multiple plans may be produced for one partition. Currently, these plans are concatenated and returned; they will be missing any root-level e.g. aggregations/joins.
This PR ignores the "if one partition then materialize with inner planners" logic when the inner planners return more than one plan.
For example, plans prior to this PR may be produced as:
Now, root plans will be correct because materialization proceeds through the ShardKeyRegexPlanner's
walkLogicalPlanTree
when inner planners produce more than one plan: