Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(coordinator) cleanup and fixes for ExecPlans to/from proto conversions #1717

Merged
merged 2 commits into from
Feb 28, 2024

Conversation

kvpetrov
Copy link
Contributor

@kvpetrov kvpetrov commented Feb 17, 2024

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :
Integration tests would not succeed if proto execution plans are used.

New behavior :
Integration tests would succeed if proto execution plans are used.

Other information:

@kvpetrov kvpetrov changed the title cleanup of imports and adding handling of transformers fix(coordinator) cleanup of imports and adding handling of transformers Feb 28, 2024
@kvpetrov kvpetrov changed the title fix(coordinator) cleanup of imports and adding handling of transformers fix(coordinator) cleanup and fixes for ExecPlans to/from proto conversions Feb 28, 2024
@kvpetrov kvpetrov requested a review from sandeep6189 February 28, 2024 22:16
@kvpetrov kvpetrov merged commit e2f68d4 into filodb:develop Feb 28, 2024
1 check passed
sandeep6189 pushed a commit to sandeep6189/FiloDB that referenced this pull request Feb 29, 2024
…sions (filodb#1717)

* cleanup of imports and adding handling of transformers

* fixes for conversion and ActorRef serialization

---------

Co-authored-by: Kier Petrov <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants