Merge branch 'develop' into 0.9.25.integration #1719
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ation issue in TsCardReduceExec (filodb#1696) * Add dataset to overflow for cardinality v2 api * fixing the aggregation bug when overflow happens
* fix unary expressions. 1. support queries with multiple unary sign such as -+--foo 2. fix rhs scalar unary expression. Basically, the right plan for this case should be ScalarBinaryOperationExec instead of BinaryJoinExec. --------- Co-authored-by: Yu Zhang <[email protected]>
…f monix observable (filodb#1700) This PR applies to the streaming query result capability which is disabled by default behind a feature flag. It appears that Pipe in monix, unlike what documentation informs, double-subscribes from source. This PR introduces caching child plan results to avoid double subscribe. Now query results are consistent and not flaky between multiple runs. PR includes detailed unit testing of streaming plan dispatch, execution and result verification. TODO in later PRs: reduce memory by removing caching.
…odb#1708) Number of samples queried is currently valued same whether or not the sample is a histogram or a counter. This PR adds a factor to histogram buckets so the number accounts for bigger histogram samples
…en present in suffix (filodb#1707) * fix(query): remove _bucket only when in suffix
…ans (filodb#1705) * Protobuf definitions of all of the execution plans * updating for changes in exec plans * accommodating changes in TsCardExec --------- Co-authored-by: Kier Petrov <[email protected]>
Groups sets of shard-keys together into individual plans before sending them remotely or executing locally. Keys are combined into individual plans with pipe-concatenated regex filters (filter1=~"foo|bar|baz"). This will reduce the total count of executed plans; the total per-query overhead is reduced.
Plans are materialized directly by inner planners when they draw data from one partition. However, when the ShardKeyRegexPlanner fanout batch size is small enough, multiple plans may be produced for one partition. Higher-level coordination is then needed for e.g. aggregations. This commit re-materializes plans with higher-level coordination from the ShardKeyRegexPlanner when batching produces more than one plan.
…plan don't apply le label filter (filodb#1715) * Adding RangeVectorTransformer for le filter for PeriodicSeriesWithWindowing
…rams (filodb#1712) * Adding Min Max Histogram Schemas
yu-shipit
previously approved these changes
Feb 20, 2024
alextheimer
approved these changes
Feb 22, 2024
sandeep6189
approved these changes
Feb 22, 2024
srivik
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: