fix @modifier for multiple partition time series. #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alextheimer
approved these changes
Feb 29, 2024
There was a problem hiding this comment.
Thanks @yu-shipit for the ultra-quick PR -- especially these tests as well 🙏
As discussed offline:
| @@ -64,7 +65,8 @@ object LogicalPlanParser { | |||
|
|
|||
| private def periodicSeriesToQuery(periodicSeries: PeriodicSeries): String = { | |||
| // Queries like sum(foo) should not have window even though stale lookback is present | |||
| s"${rawSeriesLikeToQuery(periodicSeries.rawSeries, false)}" | |||
| val at = periodicSeries.atMs.fold("")(atMs => s" $At${atMs / 1000}") | |||
There was a problem hiding this comment.
What do you think about using map and orElse here? fold implies atMs is a sequence, I think.
sandeep6189
pushed a commit
to sandeep6189/FiloDB
that referenced
this pull request
Feb 29, 2024
* fix @modifier for multiple partition time series. --------- Co-authored-by: Yu Zhang <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
New behavior :
BREAKING CHANGES
If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.
Breaking changes may include:
Other information: