feat(query): Add metrics for failover #1856
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvpetrov
changed the title
alextheimer
approved these changes
Sep 26, 2024
| @@ -360,6 +384,7 @@ class HighAvailabilityPlanner(dsRef: DatasetRef, | |||
| buddyGrpcEndpoint = Some(remoteGrpcEndpoint.get) | |||
| ) | |||
| val context = qContext.copy(plannerParams = haPlannerParams) | |||
| logger.info(context.getQueryLogLine("Using shard level failover")) | |||
There was a problem hiding this comment.
It would be useful to have lists of shards such as:
Materializing locally: [0, 1, 2, 3]
Materializing on buddy: [4, 5, 6, 7]
I know technically that info exists in the plan structure, but this would be a nice quick reference to have.
kvpetrov
added a commit
to kvpetrov/FiloDB
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Kier Petrov <[email protected]>
kvpetrov
added a commit
to kvpetrov/FiloDB
that referenced
this pull request
Sep 27, 2024
Co-authored-by: Kier Petrov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)
If query server fails over to the buddy cluster because local FiloDB clusters have shard(s) down no metric is emitted.
New behavior :
Now we emit 4 metrics:
BREAKING CHANGES
N/A