Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query) the schema provided by _type_ does not match colIDs in the… #1868

Merged
merged 1 commit into from
Oct 21, 2024

Conversation

yu-shipit
Copy link
Contributor

@yu-shipit yu-shipit commented Oct 9, 2024

… data.

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior : (link exiting issues here : https://help.github.com/articles/basic-writing-and-formatting-syntax/#referencing-issues-and-pull-requests)

New behavior :

BREAKING CHANGES

If this PR contains a breaking change, please describe the impact and migration
path for existing applications.
If not please remove this section.

Breaking changes may include:

  • Any schema changes to any Cassandra tables
  • The serialized format for Dataset and Column (see .toString methods)
  • Over the wire formats for Akka messages / case classes
  • Changes to the HTTP public API
  • Changes to query parsing / PromQL parsing

Other information:

@yu-shipit yu-shipit force-pushed the develop branch 2 times, most recently from a6c86f3 to 55c52ac Compare October 10, 2024 04:45
Copy link
Contributor

@alextheimer alextheimer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @yu-shipit 🙏
Approving for the sake of forward momentum, but please do add a log-line or metric here if that wouldn't impact performance significantly (understood: that might be a problem here, so ignore my suggestion if you agree)

@yu-shipit yu-shipit merged commit fd59ebb into filodb:develop Oct 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants