feat(query): Support multiple aggregation rules for HierarchicalQueryExperience logicalPlan update #1869
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sandeep6189
changed the title
yu-shipit
reviewed
Oct 14, 2024
query/src/main/scala/filodb/query/util/HierarchicalQueryExperience.scala
Outdated
Show resolved
Hide resolved
yu-shipit
approved these changes
Oct 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Current behavior : (link exiting issues here : LogicalPlan updates for hierarchical query experience expects metrics using the same aggregation suffix.
New behavior : Adding support for specifying multiple aggregation suffixes and rules and the logical plan update will appropriately pick up the suffix to be used.
Example query for which the hierarchical logical plan updated will be now supported: