feat(core): OTel Exponential Histograms #1879
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishramachandran
requested review from
amolnayak311,
sandeep6189 and
sherali42
sandeep6189
reviewed
Nov 5, 2024
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
memory/src/main/scala/filodb.memory/format/vectors/Histogram.scala
Outdated
Show resolved
Hide resolved
memory/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala
Outdated
Show resolved
Hide resolved
sandeep6189
reviewed
Nov 5, 2024
memory/src/main/scala/filodb.memory/format/vectors/HistogramVector.scala
Outdated
Show resolved
Hide resolved
vishramachandran
changed the title
vishramachandran
force-pushed
the
otel-exp-histograms
branch
from
41fa627 to
5dce636
Compare
vishramachandran
force-pushed
the
otel-exp-histograms
branch
from
af7d743 to
246e381
Compare
sandeep6189
approved these changes
Nov 13, 2024
| val b = it.next() | ||
| val zeroBucket = (b == 0) | ||
| val bucketUpper = bucketTop(b) | ||
| val bucketLower = if (b == 0) 0.0 else bucketTop(b - 1) |
There was a problem hiding this comment.
nitpick - if (zeroBucket) 0.0 else bucketTop(b - 1)
same for prevBucketVal
There was a problem hiding this comment.
I'll fix in my next PR :)
| @@ -160,6 +262,9 @@ final case class LongHistogram(buckets: HistogramBuckets, values: Array[Long]) e | |||
| s"Expected: ${buckets}, Found: ${other.buckets}" | |||
| ) | |||
| } | |||
| // TODO if otel histogram, the need to add values in a different way | |||
| // see if we can refactor since MutableHistogram also has this logic | |||
| assert(other.buckets == buckets) | |||
There was a problem hiding this comment.
nitpick: wondering if this check is redundant, since the previous if check does the same thing ?
There was a problem hiding this comment.
ah yes - this is from a merge conflict that I needed to resolve. I'll remove in my next PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Open Telemetry Exponential Histograms Part 1 includes:
rate,sumandhistogram_quantilefunctions testedhistogram_fractionBenchmarks show that increasing the number of buckets does not significantly impact performance. Increasing buckets by 700% (8x) reduced throughput by just 11.6% (0.116x).
Coming in later PRs
ratecalculation with counter correction for cumulative exponential histograms