-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Min-max versions of histogram quantile and fraction for exp histograms #1891
Merged
vishramachandran
merged 8 commits into
filodb:develop
from
vishramachandran:min-max-functions-exp-histograms
Dec 3, 2024
Merged
feat(core): Min-max versions of histogram quantile and fraction for exp histograms #1891
vishramachandran
merged 8 commits into
filodb:develop
from
vishramachandran:min-max-functions-exp-histograms
Dec 3, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vishramachandran
force-pushed
the
min-max-functions-exp-histograms
branch
from
November 21, 2024 22:49
a3861f4
to
e0a8788
Compare
vishramachandran
force-pushed
the
min-max-functions-exp-histograms
branch
3 times, most recently
from
November 25, 2024 13:28
4f233d1
to
a736903
Compare
vishramachandran
force-pushed
the
min-max-functions-exp-histograms
branch
from
December 2, 2024 18:08
9eb1a01
to
82a40ca
Compare
sandeep6189
previously approved these changes
Dec 2, 2024
query/src/main/scala/filodb/query/exec/rangefn/AggrOverTimeFunctions.scala
Outdated
Show resolved
Hide resolved
thank you for adding unit test @vishramachandran |
sandeep6189
approved these changes
Dec 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request checklist
Use min and max when available to calculate better quantiles and fractions.
Updated perf test results for quantiles with exponential histograms are shown below. There is a proportional degradation of performance as the number of buckets increase. Thus, exponential histograms will benefit from pre-aggregation when a large number of time series is involved. Note these results supersede the results in earlier exponential histogram PR.
Fitted Linear Regression:
JMH Benchamark CPU Profile