Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(query): delete validation for "split" queries contain binary joins with offsets #1910

Merged
merged 7 commits into from
Dec 13, 2024
Merged

feat(query): delete validation for "split" queries contain binary joins with offsets #1910

merged 7 commits into from
Dec 13, 2024

Conversation

Boyuan-Yu
Copy link
Contributor

@Boyuan-Yu Boyuan-Yu commented Dec 10, 2024 •
edited
Loading

Pull Request checklist

  • The commit(s) message(s) follows the contribution guidelines ?
  • Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :

  • It will throw this exception because of validation.

invalid_query: This query contains selectors that individually read data from multiple partitions. This is likely because a selector's data was migrated between partitions. These "split" queries cannot contain binary joins with offsets.

  • maxRemoteRawExportTimeRange is 3 days

New behavior :

  • It handles the "split" query correctly.
  • Increased the maxRemoteRawExportTimeRange to 31 days so that remote raw export is supported for longer days.

@Boyuan-Yu Boyuan-Yu marked this pull request as ready for review December 11, 2024 23:24
@alextheimer alextheimer merged commit 6cc8a24 into filodb:develop Dec 13, 2024
1 check passed
alextheimer pushed a commit to alextheimer/FiloDB that referenced this pull request Dec 13, 2024
@Boyuan-Yu @alextheimer
feat(query): delete validation for "split" queries contain binary joi…
afa6397 
…ns with offsets (filodb#1910)

Co-authored-by: Brian-Yu <[email protected]>
alextheimer pushed a commit to alextheimer/FiloDB that referenced this pull request Dec 13, 2024
@Boyuan-Yu @alextheimer
feat(query): delete validation for "split" queries contain binary joi…
1726f74 
…ns with offsets (filodb#1910)

Co-authored-by: Brian-Yu <[email protected]>
alextheimer added a commit that referenced this pull request Dec 13, 2024
@alextheimer
cherry-pick: feat(query): delete validation for "split" queries conta…
1b6a409 
…in binary joins with offsets (#1910)
alextheimer added a commit that referenced this pull request Dec 13, 2024
@alextheimer
cherry-pick: feat(query): delete validation for "split" queries conta…
8a8132c 
…in binary joins with offsets (#1910)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alextheimer alextheimer alextheimer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Boyuan-Yu @alextheimer