Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(query): reducing size of proto execution plans #1916

Merged
merged 4 commits into from
Dec 18, 2024

Conversation

kvpetrov
Copy link
Contributor

@kvpetrov kvpetrov commented Dec 18, 2024

Pull Request checklist

  • [ X ] The commit(s) message(s) follows the contribution guidelines ?
  • [ X ] Tests for the changes have been added (for bug fixes / features) ?
  • Docs have been added / updated (for bug fixes / features) ?

Current behavior :
Execution plans contain query context that can be repeated multiple times.

New behavior :
Taking the query context out of the protobuf execution plans and sending the context separately.

BREAKING CHANGES
The feature should be turned on only after full rollout. FiloDBs, QueryServers with the new version cannot talk to the older version.

Other information:

@kvpetrov kvpetrov changed the title Reducing size of proto execution plans fix(query): reducing size of proto execution plans Dec 18, 2024
Copy link
Contributor

@yu-shipit yu-shipit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just wondering if we can customized the serialization/deserialization to avoid the protocol change.

@kvpetrov kvpetrov merged commit 8a15d74 into filodb:develop Dec 18, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants