Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the monitoring option documentation #146

Merged
merged 1 commit into from
Sep 18, 2023
Merged

Conversation

Finesse
Copy link
Member

@Finesse Finesse commented Sep 16, 2023

A business decision. DM me if you need more details.

@Finesse Finesse requested a review from xnerhu September 16, 2023 10:10
@Finesse Finesse self-assigned this Sep 16, 2023
@Finesse Finesse force-pushed the chore/hide-monitoring branch from 2496f19 to e66cf4d Compare September 16, 2023 10:16
@xnerhu xnerhu merged commit 9705953 into main Sep 18, 2023
3 checks passed
@Finesse Finesse deleted the chore/hide-monitoring branch September 19, 2023 01:07
@kianandersson
Copy link

👎🏻

@Finesse
Copy link
Member Author

Finesse commented Nov 24, 2023

The option is still there, it's just not documented

@kianandersson
Copy link

The option is still there, it's just not documented

First of all, it is just bad practice to deliberately try to hide this type of option.

Second, you could at least make sure Your types support the option without @ts-ignore by using unknown instead of never.

@xnerhu
Copy link
Contributor

xnerhu commented Nov 24, 2023

The option is still there, it's just not documented

First of all, it is just bad practice to deliberately try to hide this type of option.

Second, you could at least make sure Your types support the option without @ts-ignore by using unknown instead of never.

Released 1.7.2. with changed the definitions to export async function load(options?: Record<keyof any, any>)

@JuroUhlar
Copy link

Hi @kianandersson, you are right, this change was unintended, here is a PR adding the types and documentation back in, it should be merged shortly: #156

Thank you for your feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants