fix: improve lit static bundle size #160
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
digitalsadhu
requested review from
wkillerud,
leftieFriele,
tor0405 and
flatoy
wkillerud
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After discussion here lit/lit.dev#1285 I've had a crack at improving things re: the Lit static bundle.
This PR reduces the bundle size of the Lit static bundle from 8kb to 1kb at the cost of an extra request.
However, since the mapping is to the main lit bundle, in most cases the user will already have this file in browser cache and won't pay the hit. (Also since the main lit bundle is typically preloaded).