Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for querying sub-collections #14

Merged
merged 2 commits into from
Sep 18, 2023

Conversation

aliyome
Copy link
Contributor

@aliyome aliyome commented Sep 16, 2023

#13

The existing query method did not support fetching all documents from a sub-collection. This commit modifies the endpoint dynamically based on additional arguments to allow querying against sub-collections.

The existing `query` method did not support fetching all documents from a sub-collection.
This commit modifies the endpoint dynamically based on additional arguments to allow querying against sub-collections.
@aliyome aliyome changed the title Add support for querying sub-collections (#13) Add support for querying sub-collections Sep 16, 2023
(internal) refactored endpoints constructor
Copy link
Member

@alexiglesias93 alexiglesias93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!
I've pushed a commit to refactor the endpoint constructor a little bit.

@alexiglesias93 alexiglesias93 merged commit 3335f88 into finsweet:master Sep 18, 2023
1 check passed
@aliyome
Copy link
Contributor Author

aliyome commented Sep 18, 2023

Thank you!!!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants