Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Activity indicator is displayed in black only during the process #1207

Closed
shosokawa opened this issue Sep 6, 2024 · 3 comments · Fixed by #1212
Closed

Activity indicator is displayed in black only during the process #1207

shosokawa opened this issue Sep 6, 2024 · 3 comments · Fixed by #1212

Comments

@shosokawa
Copy link

Step 2: Describe your environment

  • Objective C or Swift: Swift
  • iOS version: 17.5.1
  • Firebase SDK version: 11.1.0
  • FirebaseUI version: 14.2.4

Step 3: Describe the problem:

Activity indicator is displayed in black only.

IMG_BBC47D495EC5-1

Steps to reproduce:

  1. Uses FUIPhoneAuth
        FeedbackGenerator.run(event: .tap)
      let authUI = FUIAuth.defaultAuthUI()!
      authUI.delegate = self
      authUI.providers = [FUIPhoneAuth(authUI: authUI)]
      let provider = authUI.providers.first as! FUIPhoneAuth
      provider.signIn(withPresenting: self, phoneNumber: nil)
  1. Follows the instructions to enter your phone number and code

Observed Results:

Activity indicator is displayed as "black square"

Expected Results:

Activity indicator is displayed as "indicator on black square"

Relevant Code:

I guess that this change on #1194 is the cause.

I tried to restore the style to UIActivityIndicatorViewStyleWhiteLarge from UIActivityIndicatorViewStyleLarge locally and it worked.
IMG_6CC5953CF6DB-1

But UIActivityIndicatorViewStyleWhiteLarge is marked deprecated

@nimamogh
Copy link

same issue here

@paulb777
Copy link
Member

Thanks for the fix @willbattel. It's now in version 14.2.6 for Swift Package Manager and new FirebaseAuthUI podspec with the fix should be published tomorrow.

@nimamogh
Copy link

thanks for the fix. it displays correctly on v 14.2.6 now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants