Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Various release updates #1194

Merged
merged 1 commit into from
Jul 24, 2024
Merged

Various release updates #1194

merged 1 commit into from
Jul 24, 2024

Conversation

paulb777
Copy link
Member

@paulb777 paulb777 commented Jul 24, 2024

  • Comprehensive update to version 14.2.0
  • Add a staging.sh script
  • Add --allow-warnings to allow warnings in builds from recent Xcode versions
  • Fix a few of the warnings

podspecs staged on SpecsStaging now and planning to publish release tomorrow.

@paulb777 paulb777 requested a review from morganchen12 July 24, 2024 22:45
@paulb777 paulb777 merged commit e3dbca5 into main Jul 24, 2024
26 checks passed
@paulb777 paulb777 deleted the pb-release-updates branch July 24, 2024 22:53
@willbattel
Copy link
Contributor

Hey @paulb777 when you have a chance could you take a peek at #1207? Seems to have been caused by the UIActivityIndicatorViewStyle change in this PR. If I'm not mistaken, I think the activity indicator view just needs its color set to white after you set the style--as the default for that style is dark grey which doesn't show on the black background.

https://developer.apple.com/documentation/uikit/uiactivityindicatorview/1622836-color?language=objc

@paulb777
Copy link
Member Author

That sounds reasonable. Do you want try out your proposed fix and send us a PR?

@willbattel
Copy link
Contributor

That sounds reasonable. Do you want try out your proposed fix and send us a PR?

Sure. I can take a crack at it as soon as I have time.

paulb777 pushed a commit that referenced this pull request Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants