Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Package.swift #1185

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Update Package.swift #1185

wants to merge 3 commits into from

Conversation

ArturoLee
Copy link
Contributor

Bumped FBSDK to v17. Archive validation now works in Xcode v15.3.

Bumped FBSDK to v17
Bumped FBSDK to 17.0
Copy link
Contributor

@morganchen12 morganchen12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@@ -9,7 +9,7 @@ target 'FirebaseFacebookAuthUI' do
# The facebook pods generate an unreasonable number of warnings.
inhibit_all_warnings!

pod 'FBSDKLoginKit', '~> 16.0'
pod 'FBSDKLoginKit', '~> 17.0'
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You'll need to run pod update in this directory to fix the build issue.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran pod update but it still didn't pass. I think it is because the library is using some deprecated methods.

  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseAuthUI/Sources/FUIAccountSettingsOperationUpdateEmail.m:80:37: warning: 'updateEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. Use sendEmailVerification(beforeUpdatingEmail email: String) instead. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailEntryViewController.m:151:14: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailAuth.m:524:21: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]



  • WARN | xcodebuild: /Users/runner/work/FirebaseUI-iOS/FirebaseUI-iOS/FirebaseEmailAuthUI/Sources/FUIEmailAuth.m:646:21: warning: 'fetchSignInMethodsForEmail:completion:' is deprecated: This method is deprecated and will be removed in a future release. This method returns an empty list when Email Enumeration Protection is enabled. [-Wdeprecated-declarations]

@maddiemcdowell
Copy link

Package.swift is giving me an error in xcode that says that the package manifest cannot be accessed. Is this a current issue that it being actively worked on?

@peoplemerge
Copy link

peoplemerge commented Oct 7, 2024

I'd also see this be actively worked on. SwiftPM Developers cannot use FirebaseUI without pain.
Edit: the specific error trying to add FirebaseUI-iOS from https://github.com/firebase/FirebaseUI-iOS.git is: "unable to find /Package.swift"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants