Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integration Test Target Setup #10

Merged
merged 4 commits into from
Sep 19, 2024
Merged

Conversation

aashishpatil-g
Copy link
Collaborator

Adds an Integration Test Target.

Tests cannot be run within a git action as yet but I've run them manually locally and they are executing successfully.

@paulb777
Copy link
Member

Looks like copyrights are getting deleted

@aashishpatil-g
Copy link
Collaborator Author

Looks like copyrights are getting deleted

Sorry about that. Missed them in the generated code. Added now.

@paulb777
Copy link
Member

Consider using an environment variable like in #8 to wrap integration tests so CI can succeed.

I'll investigate working around the CI issue in another PR with less parallelization

@aashishpatil-g aashishpatil-g force-pushed the ap/integrationTestTarget branch from 87edca7 to 943427d Compare September 19, 2024 21:57
@aashishpatil-g
Copy link
Collaborator Author

Consider using an environment variable like in #8 to wrap integration tests so CI can succeed.

I'll investigate working around the CI issue in another PR with less parallelization

Added a flag to disable integration tests and added this flag to the spm.yml

@aashishpatil-g aashishpatil-g merged commit b6b8e1a into main Sep 19, 2024
3 of 18 checks passed
@aashishpatil-g aashishpatil-g deleted the ap/integrationTestTarget branch September 19, 2024 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants