Fix crash in Auth when running unit tests #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulb777
reviewed
Sep 17, 2024
There was a problem hiding this comment.
Please fix formatting and address this TODO - https://github.com/firebase/data-connect-ios-sdk/blob/main/.github/workflows/spm.yml#L45
|
May also need to make separate targets in Package.swift for unit and integration tests |
paulb777
approved these changes
Sep 17, 2024
|
Yes, Unit tests are succeeding locally. I'll start a separate PR to fix the TODO and create a separate Unit Test target |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the crash in Auth when running Unit Tests. This is because the Auth SDK expects an API key in 11.x SDK. The tests were not supplying a dummy key.