Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove dead protos #6362

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Remove dead protos #6362

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a56581f
Remove dead protos
tom-andersen Oct 9, 2024
8c9a3a4
Merge branch 'main' into tomandersen/cleanupProtos
tom-andersen Oct 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
30 changes: 0 additions & 30 deletions firebase-firestore/src/proto/google/apphosting/datastore/testing/datastore_test_trace.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,31 +57,6 @@ message ValidationRule {
message FirestoreV1Action {
// Non-streaming ops in the Firestore service API.
// See: firestore/v1/firestore.proto
message GetDocument {
.google.firestore.v1.GetDocumentRequest request = 1;
.google.firestore.v1.Document response = 2;
}

message ListDocuments {
.google.firestore.v1.ListDocumentsRequest request = 1;
.google.firestore.v1.ListDocumentsResponse response = 2;
}

message CreateDocument {
.google.firestore.v1.CreateDocumentRequest request = 1;
.google.firestore.v1.Document response = 2;
}

message UpdateDocument {
.google.firestore.v1.UpdateDocumentRequest request = 1;
.google.firestore.v1.Document response = 2;
}

message DeleteDocument {
.google.firestore.v1.DeleteDocumentRequest request = 1;
.google.protobuf.Empty response = 2;
}

message BeginTransaction {
.google.firestore.v1.BeginTransactionRequest request = 1;
.google.firestore.v1.BeginTransactionResponse response = 2;
Expand Down Expand Up @@ -128,11 +103,6 @@ message FirestoreV1Action {
}

oneof action {
GetDocument get_document = 1;
ListDocuments list_documents = 2;
CreateDocument create_document = 3;
UpdateDocument update_document = 4;
DeleteDocument delete_document = 5;
BeginTransaction begin_transaction = 6;
Commit commit = 7;
Rollback rollback = 8;
Expand Down
182 changes: 0 additions & 182 deletions firebase-firestore/src/proto/google/firestore/v1/firestore.proto
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,43 +54,6 @@ option php_namespace = "Google\\Cloud\\Firestore\\V1";
// committed. Any read with an equal or greater `read_time` is guaranteed
// to see the effects of the transaction.
service Firestore {
// Gets a single document.
rpc GetDocument(GetDocumentRequest) returns (Document) {
option (google.api.http) = {
get: "/v1/{name=projects/*/databases/*/documents/*/**}"
};
}

// Lists documents.
rpc ListDocuments(ListDocumentsRequest) returns (ListDocumentsResponse) {
option (google.api.http) = {
get: "/v1/{parent=projects/*/databases/*/documents/*/**}/{collection_id}"
};
}

// Creates a new document.
rpc CreateDocument(CreateDocumentRequest) returns (Document) {
option (google.api.http) = {
post: "/v1/{parent=projects/*/databases/*/documents/**}/{collection_id}"
body: "document"
};
}

// Updates or inserts a document.
rpc UpdateDocument(UpdateDocumentRequest) returns (Document) {
option (google.api.http) = {
patch: "/v1/{document.name=projects/*/databases/*/documents/*/**}"
body: "document"
};
}

// Deletes a document.
rpc DeleteDocument(DeleteDocumentRequest) returns (google.protobuf.Empty) {
option (google.api.http) = {
delete: "/v1/{name=projects/*/databases/*/documents/*/**}"
};
}

// Gets multiple documents.
//
// Documents returned by this method are not guaranteed to be returned in the
Expand Down Expand Up @@ -190,151 +153,6 @@ service Firestore {
}
}

// The request for [Firestore.GetDocument][google.firestore.v1.Firestore.GetDocument].
message GetDocumentRequest {
// The resource name of the Document to get. In the format:
// `projects/{project_id}/databases/{database_id}/documents/{document_path}`.
string name = 1;

// The fields to return. If not set, returns all fields.
//
// If the document has a field that is not present in this mask, that field
// will not be returned in the response.
DocumentMask mask = 2;

// The consistency mode for this transaction.
// If not set, defaults to strong consistency.
oneof consistency_selector {
// Reads the document in a transaction.
bytes transaction = 3;

// Reads the version of the document at the given time.
// This may not be older than 60 seconds.
google.protobuf.Timestamp read_time = 5;
}
}

// The request for [Firestore.ListDocuments][google.firestore.v1.Firestore.ListDocuments].
message ListDocumentsRequest {
// The parent resource name. In the format:
// `projects/{project_id}/databases/{database_id}/documents` or
// `projects/{project_id}/databases/{database_id}/documents/{document_path}`.
// For example:
// `projects/my-project/databases/my-database/documents` or
// `projects/my-project/databases/my-database/documents/chatrooms/my-chatroom`
string parent = 1;

// The collection ID, relative to `parent`, to list. For example: `chatrooms`
// or `messages`.
string collection_id = 2;

// The maximum number of documents to return.
int32 page_size = 3;

// The `next_page_token` value returned from a previous List request, if any.
string page_token = 4;

// The order to sort results by. For example: `priority desc, name`.
string order_by = 6;

// The fields to return. If not set, returns all fields.
//
// If a document has a field that is not present in this mask, that field
// will not be returned in the response.
DocumentMask mask = 7;

// The consistency mode for this transaction.
// If not set, defaults to strong consistency.
oneof consistency_selector {
// Reads documents in a transaction.
bytes transaction = 8;

// Reads documents as they were at the given time.
// This may not be older than 60 seconds.
google.protobuf.Timestamp read_time = 10;
}

// If the list should show missing documents. A missing document is a
// document that does not exist but has sub-documents. These documents will
// be returned with a key but will not have fields, [Document.create_time][google.firestore.v1.Document.create_time],
// or [Document.update_time][google.firestore.v1.Document.update_time] set.
//
// Requests with `show_missing` may not specify `where` or
// `order_by`.
bool show_missing = 12;
}

// The response for [Firestore.ListDocuments][google.firestore.v1.Firestore.ListDocuments].
message ListDocumentsResponse {
// The Documents found.
repeated Document documents = 1;

// The next page token.
string next_page_token = 2;
}

// The request for [Firestore.CreateDocument][google.firestore.v1.Firestore.CreateDocument].
message CreateDocumentRequest {
// The parent resource. For example:
// `projects/{project_id}/databases/{database_id}/documents` or
// `projects/{project_id}/databases/{database_id}/documents/chatrooms/{chatroom_id}`
string parent = 1;

// The collection ID, relative to `parent`, to list. For example: `chatrooms`.
string collection_id = 2;

// The client-assigned document ID to use for this document.
//
// Optional. If not specified, an ID will be assigned by the service.
string document_id = 3;

// The document to create. `name` must not be set.
Document document = 4;

// The fields to return. If not set, returns all fields.
//
// If the document has a field that is not present in this mask, that field
// will not be returned in the response.
DocumentMask mask = 5;
}

// The request for [Firestore.UpdateDocument][google.firestore.v1.Firestore.UpdateDocument].
message UpdateDocumentRequest {
// The updated document.
// Creates the document if it does not already exist.
Document document = 1;

// The fields to update.
// None of the field paths in the mask may contain a reserved name.
//
// If the document exists on the server and has fields not referenced in the
// mask, they are left unchanged.
// Fields referenced in the mask, but not present in the input document, are
// deleted from the document on the server.
DocumentMask update_mask = 2;

// The fields to return. If not set, returns all fields.
//
// If the document has a field that is not present in this mask, that field
// will not be returned in the response.
DocumentMask mask = 3;

// An optional precondition on the document.
// The request will fail if this is set and not met by the target document.
Precondition current_document = 4;
}

// The request for [Firestore.DeleteDocument][google.firestore.v1.Firestore.DeleteDocument].
message DeleteDocumentRequest {
// The resource name of the Document to delete. In the format:
// `projects/{project_id}/databases/{database_id}/documents/{document_path}`.
string name = 1;

// An optional precondition on the document.
// The request will fail if this is set and not met by the target document.
Precondition current_document = 2;
}

// The request for [Firestore.BatchGetDocuments][google.firestore.v1.Firestore.BatchGetDocuments].
message BatchGetDocumentsRequest {
// The database name. In the format:
Expand Down
Loading