-
Notifications
You must be signed in to change notification settings - Fork 958
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python Admin SDK Fixes #4423
Python Admin SDK Fixes #4423
Conversation
…ython-admin-sdk-support
…ython-admin-sdk-support
…/firebase-tools into jm/python-admin-sdk-support
…ython-admin-sdk-support
Handled downstream
…ython-admin-sdk-support
Codecov ReportBase: 56.27% // Head: 56.28% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #4423 +/- ##
=======================================
Coverage 56.27% 56.28%
=======================================
Files 309 309
Lines 20830 20830
Branches 4229 4229
=======================================
+ Hits 11723 11725 +2
+ Misses 8095 8093 -2
Partials 1012 1012
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Is it typical for integration tests to be skipped? I saw @Yuangwang attempting to retry the workflow.. please let me know if anything needs to be changed on my end to get this to work. |
Our github actions are setup in a way that the integration tests won't run on external contributions. I made a clone of the pr here to run all the other tests https://github.com/firebase/firebase-tools/pull/5303/files. I think the new test is breaking right now. You should be able to run |
…ython-admin-sdk-support
The changes in my PR are superceded by b0798fb |
Description
Makes a few backwards compatible changes to support the Python Firebase Admin SDK.
fix: support multipart upload boundaryId with quotesfix: support lower-case content typefix: add tertiary path for getting blobScenarios Tested
googleapis/python-storage#752 (comment)
Sample Commands
Use @qhaas's test script to test the changes. googleapis/python-storage#752 (comment)
Relies on changes in googleapis/python-storage#761 to work properly.