Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python Admin SDK Fixes #4423

Closed

Conversation

jack-michaud
Copy link

@jack-michaud jack-michaud commented Apr 8, 2022

Description

Makes a few backwards compatible changes to support the Python Firebase Admin SDK.

  • fix: support multipart upload boundaryId with quotes
  • fix: support lower-case content type
  • fix: add secondary path for deleting blob
  • fix: add tertiary path for getting blob

Scenarios Tested

googleapis/python-storage#752 (comment)

Sample Commands

Use @qhaas's test script to test the changes. googleapis/python-storage#752 (comment)

Relies on changes in googleapis/python-storage#761 to work properly.

@jack-michaud jack-michaud marked this pull request as ready for review August 3, 2022 20:18
@tonyjhuang tonyjhuang requested a review from Yuangwang August 4, 2022 14:51
@codecov-commenter
Copy link

Codecov Report

Base: 56.27% // Head: 56.28% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (ce064b7) compared to base (e1872a4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #4423   +/-   ##
=======================================
  Coverage   56.27%   56.28%           
=======================================
  Files         309      309           
  Lines       20830    20830           
  Branches     4229     4229           
=======================================
+ Hits        11723    11725    +2     
+ Misses       8095     8093    -2     
  Partials     1012     1012           
Impacted Files Coverage Δ
src/emulator/storage/apis/gcloud.ts 5.39% <0.00%> (ø)
src/emulator/auth/state.ts 85.43% <0.00%> (+0.56%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@jack-michaud
Copy link
Author

Is it typical for integration tests to be skipped? I saw @Yuangwang attempting to retry the workflow.. please let me know if anything needs to be changed on my end to get this to work.

@Yuangwang
Copy link
Contributor

Our github actions are setup in a way that the integration tests won't run on external contributions. I made a clone of the pr here to run all the other tests https://github.com/firebase/firebase-tools/pull/5303/files.

I think the new test is breaking right now. You should be able to run npm run test:storage-emulator-integration to debug locally before pushing.

@jack-michaud
Copy link
Author

The changes in my PR are superceded by b0798fb

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants