Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip quotes in storage emulator header boundaryId #4825

Merged

Conversation

Yuangwang
Copy link
Contributor

Description

Strip quotes in storage emulator header boundaryId since some gcs sdks send in additional quotes. Fixes part of #3953

Scenarios Tested

Manual testing with the setup described in #3953 and also added unit test for this specific case

@Yuangwang Yuangwang requested review from tonyjhuang and abhis3 August 3, 2022 18:00
@tonyjhuang
Copy link
Contributor

Is the goal to eventually handle these test cases from #3953 as well?

multipart/related; boundary="===============2559276420576958297=="
multipart/related; boundary================2559276420576958297==
multipart/related; boundary=---------------------------974767299852498929531610575

@Yuangwang
Copy link
Contributor Author

Is the goal to eventually handle these test cases from #3953 as well?

multipart/related; boundary="===============2559276420576958297=="
multipart/related; boundary================2559276420576958297==
multipart/related; boundary=---------------------------974767299852498929531610575

went over this offline, we're going to target the multipart/related; boundary="===============2559276420576958297==" case specifically for now since it is passed in like that in some gcs sdks. We might revisit other cases later.

@codecov-commenter
Copy link

codecov-commenter commented Aug 3, 2022

Codecov Report

Merging #4825 (0196d55) into master (d446fff) will decrease coverage by 0.00%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #4825      +/-   ##
==========================================
- Coverage   57.73%   57.72%   -0.01%     
==========================================
  Files         287      287              
  Lines       18734    18735       +1     
  Branches     3699     3699              
==========================================
- Hits        10816    10815       -1     
- Misses       7032     7034       +2     
  Partials      886      886              
Impacted Files Coverage Δ
src/emulator/storage/multipart.ts 95.12% <100.00%> (+0.12%) ⬆️
src/emulator/auth/state.ts 84.78% <0.00%> (-0.57%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants