Skip to content

Commit

Permalink
test(perf): increase iterations for snapshot test on on intel
Browse files Browse the repository at this point in the history
The span of values (max minus min) of snapshot restore latencies on
intel instances on 5.10 and 6.1 is up to 70ms, which makes for very
inaccurate tests. Try to counteract this by collecting more samples.

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Sep 27, 2023
1 parent a22cda5 commit 1a9c002
Showing 1 changed file with 9 additions and 1 deletion.
10 changes: 9 additions & 1 deletion tests/integration_tests/performance/test_snapshot_ab.py
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,15 @@
from framework.properties import global_props

USEC_IN_MSEC = 1000
ITERATIONS = 30

# On Intel instances for kv>=5.10 we get very scattered results. To avoid false positives, collect more samples
if global_props.instance in (
"m5d.metal",
"m6i.metal",
) and global_props.host_linux_version in ("5.10", "6.1"):
ITERATIONS = 50
else:
ITERATIONS = 30


@lru_cache
Expand Down

0 comments on commit 1a9c002

Please sign in to comment.