feat: crates know their versions

Removed redundant `FIRECRACKER_VERSION` definitions from
`build.rs` in root and firecracker crate,
because `CARGO_PKG_VERSION` can be used instead.

Also removed `build.rs` from root as it is now
not used for anything.

Signed-off-by: Egor Lazarchuk <[email protected]>

src/cpu-template-helper/Cargo.toml

@@ -3,7 +3,6 @@ name = "cpu-template-helper"
 version = "1.5.0-dev"
 authors = ["Amazon Firecracker team <[email protected]>"]
 edition = "2021"
-build = "../../build.rs"
 license = "Apache-2.0"
 # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html
 

src/cpu-template-helper/src/utils/mod.rs

@@ -19,7 +19,7 @@ pub mod aarch64;
 #[cfg(target_arch = "x86_64")]
 pub mod x86_64;
 
-pub const CPU_TEMPLATE_HELPER_VERSION: &str = env!("FIRECRACKER_VERSION");
+pub const CPU_TEMPLATE_HELPER_VERSION: &str = env!("CARGO_PKG_VERSION");
 
 /// Trait for key of `HashMap`-based modifier.
 ///

src/firecracker/build.rs

@@ -18,12 +18,6 @@ const SECCOMPILER_SRC_DIR: &str = "../seccompiler/src";
 // It compiles the JSON seccomp policies into a serializable BPF format, using seccompiler-bin.
 // The generated binary code will get included in Firecracker's code, at compile-time.
 fn main() {
-    let firecracker_version = env!("CARGO_PKG_VERSION").to_string();
-    println!(
-        "cargo:rustc-env=FIRECRACKER_VERSION={}",
-        firecracker_version
-    );
-
     // Target triple
     let target = std::env::var("TARGET").expect("Missing target.");
     let out_dir = std::env::var("OUT_DIR").expect("Missing build-level OUT_DIR.");

src/firecracker/src/main.rs

@@ -36,7 +36,7 @@ use crate::seccomp::SeccompConfig;
 // see https://refspecs.linuxfoundation.org/FHS_3.0/fhs/ch03s15.html for more information.
 const DEFAULT_API_SOCK_PATH: &str = "/run/firecracker.socket";
 const DEFAULT_INSTANCE_ID: &str = "anonymous-instance";
-const FIRECRACKER_VERSION: &str = env!("FIRECRACKER_VERSION");
+const FIRECRACKER_VERSION: &str = env!("CARGO_PKG_VERSION");
 const MMDS_CONTENT_ARG: &str = "metadata";
 
 #[derive(Debug, thiserror::Error, displaydoc::Display)]

src/jailer/Cargo.toml

@@ -3,7 +3,6 @@ name = "jailer"
 version = "1.5.0-dev"
 authors = ["Amazon Firecracker team <[email protected]>"]
 edition = "2021"
-build = "../../build.rs"
 description = "Process for starting Firecracker in production scenarios; applies a cgroup/namespace isolation barrier and then drops privileges."
 homepage = "https://firecracker-microvm.github.io/"
 license = "Apache-2.0"

src/jailer/src/main.rs

@@ -18,7 +18,7 @@ mod chroot;
 mod env;
 mod resource_limits;
 
-const JAILER_VERSION: &str = env!("FIRECRACKER_VERSION");
+const JAILER_VERSION: &str = env!("CARGO_PKG_VERSION");
 
 #[derive(Debug, thiserror::Error)]
 pub enum JailerError {

src/rebase-snap/Cargo.toml

@@ -3,7 +3,6 @@ name = "rebase-snap"
 version = "1.5.0-dev"
 authors = ["Amazon Firecracker team <[email protected]>"]
 edition = "2021"
-build = "../../build.rs"
 license = "Apache-2.0"
 
 [[bin]]

src/rebase-snap/src/main.rs

@@ -9,7 +9,7 @@ use std::os::unix::io::AsRawFd;
 use utils::arg_parser::{ArgParser, Argument, Arguments, Error as ArgError};
 use utils::seek_hole::SeekHole;
 
-const REBASE_SNAP_VERSION: &str = env!("FIRECRACKER_VERSION");
+const REBASE_SNAP_VERSION: &str = env!("CARGO_PKG_VERSION");
 const BASE_FILE: &str = "base-file";
 const DIFF_FILE: &str = "diff-file";
 

src/seccompiler/Cargo.toml

@@ -3,7 +3,6 @@ name = "seccompiler"
 version = "1.5.0-dev"
 authors = ["Amazon Firecracker team <[email protected]>"]
 edition = "2021"
-build = "../../build.rs"
 description = "Program that compiles multi-threaded seccomp-bpf filters expressed as JSON into raw BPF programs, serializing them and outputting them to a file."
 homepage = "https://firecracker-microvm.github.io/"
 license = "Apache-2.0"

src/seccompiler/src/seccompiler_bin.rs

@@ -50,7 +50,7 @@ use compiler::{CompilationError, Compiler, JsonFile};
 use serde_json::error::Error as JSONError;
 use utils::arg_parser::{ArgParser, Argument, Arguments as ArgumentsBag, Error as ArgParserError};
 
-const SECCOMPILER_VERSION: &str = env!("FIRECRACKER_VERSION");
+const SECCOMPILER_VERSION: &str = env!("CARGO_PKG_VERSION");
 const DEFAULT_OUTPUT_FILENAME: &str = "seccomp_binary_filter.out";
 
 #[derive(Debug, thiserror::Error)]

src/snapshot-editor/Cargo.toml

@@ -3,7 +3,6 @@ name = "snapshot-editor"
 version = "1.5.0"
 authors = ["Amazon Firecracker team <[email protected]>"]
 edition = "2021"
-build = "../../build.rs"
 license = "Apache-2.0"
 
 [[bin]]

src/snapshot-editor/src/main.rs

@@ -26,7 +26,7 @@ enum SnapEditorError {
 }
 
 #[derive(Debug, Parser)]
-#[command(version = format!("v{}", env!("FIRECRACKER_VERSION")))]
+#[command(version = format!("v{}", env!("CARGO_PKG_VERSION")))]
 struct Cli {
     #[command(subcommand)]
     command: Command,