Skip to content

Commit

Permalink
fix(fdt): Improve reporting of errors related to FDT setup
Browse files Browse the repository at this point in the history
Change the doc comment (which also affects the implementation of
`std::fmt::Display`) for `ConfigurationError::SetupFDT` to include
the underlying `fdt::FtdError`.
This improves both the reporting of failures during FDT setup on the
logs, as well as the message in API server's corresponding HTTP
response.

Signed-off-by: Christos Katsakioris <[email protected]>
Signed-off-by: Filippos Tofalos <[email protected]>
  • Loading branch information
ckatsak authored and roypat committed Oct 24, 2024
1 parent 5ef02a8 commit 7b4adcd
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion src/vmm/src/arch/aarch64/mod.rs
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ use crate::vstate::memory::{Address, Bytes, GuestAddress, GuestMemory, GuestMemo
/// Errors thrown while configuring aarch64 system.
#[derive(Debug, thiserror::Error, displaydoc::Display)]
pub enum ConfigurationError {
/// Failed to create a Flattened Device Tree for this aarch64 microVM.
/// Failed to create a Flattened Device Tree for this aarch64 microVM: {0}
SetupFDT(#[from] fdt::FdtError),
/// Failed to compute the initrd address.
InitrdAddress,
Expand Down

0 comments on commit 7b4adcd

Please sign in to comment.