Skip to content

Commit

Permalink
test: Only submit raw data for snapshot test, not average
Browse files Browse the repository at this point in the history
Before emitting raw data, we only submitted the average to display on
our dashboards. However, ever since submitting the raw data, we could
have just instructed cloudwatch to compute averages from that, without
needing to also submit the averages. So actually switch to doing that.

Also rename network_ab's "latency" metric to "ping_latency" for backward
compatibility.

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Sep 29, 2023
1 parent d61e543 commit 98f26b8
Show file tree
Hide file tree
Showing 2 changed files with 1 addition and 7 deletions.
5 changes: 1 addition & 4 deletions tests/integration_tests/performance/test_network_ab.py
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
"""Tests the network latency of a Firecracker guest."""

import re
import statistics

import pytest

Expand Down Expand Up @@ -86,10 +85,8 @@ def test_network_latency(microvm_factory, guest_kernel, rootfs, metrics):
{"performance_test": "test_network_latency", **vm.dimensions}
)

metrics.put_metric("latency_Avg", statistics.mean(samples), "Milliseconds")

for sample in samples:
metrics.put_metric("latency", sample, "Milliseconds")
metrics.put_metric("ping_latency", sample, "Milliseconds")


class TCPIPerf3Test(IPerf3Test):
Expand Down
3 changes: 0 additions & 3 deletions tests/integration_tests/performance/test_snapshot_ab.py
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
# SPDX-License-Identifier: Apache-2.0
"""Performance benchmark for snapshot restore."""
import shutil
import statistics
import tempfile
from dataclasses import dataclass
from functools import lru_cache
Expand Down Expand Up @@ -159,7 +158,5 @@ def test_restore_latency(
}
)

metrics.put_metric("latency_Avg", statistics.mean(samples), "Milliseconds")

for sample in samples:
metrics.put_metric("latency", sample, "Milliseconds")

0 comments on commit 98f26b8

Please sign in to comment.