tests: Warn on clippy::as_conversions

`clippy::ptr_as_ptr`, `clippy::cast_lossless`, `clippy::cast_possible_truncation`, `clippy::cast_possible_wrap` and `clippy::cast_sign_loss` are all enabled by `clippy::as_conversions`, with them all enabled we can now remove them and simply warn on `clippy::as_conversions`. Signed-off-by: Jonathan Woollett-Light <[email protected]>
firecracker-microvm · Oct 9, 2023 · 9e27796 · 9e27796
1 parent 5a6f28d
commit 9e27796
Show file tree

Hide file tree

Showing 13 changed files with 15 additions and 22 deletions.
diff --git a/.cargo/config b/.cargo/config
@@ -1,12 +1,8 @@
 [build]
 target-dir = "build/cargo_target"
 rustflags = [
-  "-Wclippy::ptr_as_ptr",
+  "-Wclippy::as_conversions",
   "-Wclippy::undocumented_unsafe_blocks",
-  "-Wclippy::cast_lossless",
-  "-Wclippy::cast_possible_truncation",
-  "-Wclippy::cast_possible_wrap",
-  "-Wclippy::cast_sign_loss",
   "-Wmissing_debug_implementations",
   "-Wclippy::exit",
 ]

diff --git a/src/net_gen/src/if_tun.rs b/src/net_gen/src/if_tun.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/net_gen/src/iff.rs b/src/net_gen/src/iff.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/net_gen/src/sockios.rs b/src/net_gen/src/sockios.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/virtio_gen/src/virtio_blk.rs b/src/virtio_gen/src/virtio_blk.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/virtio_gen/src/virtio_net.rs b/src/virtio_gen/src/virtio_net.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/virtio_gen/src/virtio_ring.rs b/src/virtio_gen/src/virtio_ring.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/virtio_gen/src/virtio_rng.rs b/src/virtio_gen/src/virtio_rng.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     missing_debug_implementations
 )]

diff --git a/src/vmm/src/arch_gen/x86/hyperv.rs b/src/vmm/src/arch_gen/x86/hyperv.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     clippy::cast_lossless
 )]

diff --git a/src/vmm/src/arch_gen/x86/hyperv_tlfs.rs b/src/vmm/src/arch_gen/x86/hyperv_tlfs.rs
@@ -8,7 +8,7 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
     clippy::cast_lossless
 )]

diff --git a/src/vmm/src/arch_gen/x86/msr_index.rs b/src/vmm/src/arch_gen/x86/msr_index.rs
@@ -8,9 +8,8 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
-    clippy::undocumented_unsafe_blocks,
-    clippy::cast_lossless
+    clippy::as_conversions,
+    clippy::undocumented_unsafe_blocks
 )]
 
 pub const MSR_EFER: u32 = 0xc0000080;

diff --git a/src/vmm/src/arch_gen/x86/perf_event.rs b/src/vmm/src/arch_gen/x86/perf_event.rs
@@ -8,9 +8,8 @@
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
-    clippy::undocumented_unsafe_blocks,
-    clippy::cast_lossless
+    clippy::as_conversions,
+    clippy::undocumented_unsafe_blocks
 )]
 
 pub const MSR_ARCH_PERFMON_PERFCTR0: u32 = 0xc1;

diff --git a/tools/bindgen.sh b/tools/bindgen.sh
@@ -31,9 +31,8 @@ function fc-bindgen {
     non_upper_case_globals,
     dead_code,
     non_snake_case,
-    clippy::ptr_as_ptr,
+    clippy::as_conversions,
     clippy::undocumented_unsafe_blocks,
-    clippy::cast_lossless,
     missing_debug_implementations
 )]