Skip to content

Commit

Permalink
test: move "doing A/B-Test" print statement below ignore-check
Browse files Browse the repository at this point in the history
Move the print statement that states which A/B-Tests we're performing
below the check that filters out ignored test cases. This way, we avoid
claiming to do an A/B-Test for things that are later actually filtered
out (meaning no A/B-Test actually happens).

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Oct 16, 2024
1 parent 0f306e5 commit a31c79a
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions tools/ab_test.py
Original file line number Diff line number Diff line change
Expand Up @@ -211,9 +211,6 @@ def analyze_data(
), "A and B run produced incomparable data. This is a bug in the test!"

for metric, (values_a, unit) in metrics_a.items():
print(
f"Doing A/B-test for dimensions {dimension_set} and property {metric}"
)
result = check_regression(
values_a, metrics_b[metric][0], n_resamples=n_resamples
)
Expand Down Expand Up @@ -269,6 +266,8 @@ def analyze_data(
if is_ignored(dict(dimension_set)):
continue

print(f"Doing A/B-test for dimensions {dimension_set} and property {metric}")

values_a = processed_emf_a[dimension_set][metric][0]
baseline_mean = statistics.mean(values_a)

Expand Down

0 comments on commit a31c79a

Please sign in to comment.