Skip to content

Commit

Permalink
Remove redundant min-version check from artifacts.py
Browse files Browse the repository at this point in the history
With the new CI artifacts system, we no longer keep all firecracker
releases in a single S3 bucket, and instead keep a list of supported
firecracker releases per artifacts-bucket. This means that in the 1.6
artifacts bucket, only 1.4 and 1.5 release binaries exist. Therefore,
the additional check in firecracker_artifacts() is no longer needed. We
remove it, because it specifies the minimal version as a tuple, and is
thus easily missed when doign a release (as the runbook only hints that
sometimes min-versions are specified as strings).

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Oct 9, 2023
1 parent 4d12463 commit c001c6a
Showing 1 changed file with 0 additions and 3 deletions.
3 changes: 0 additions & 3 deletions tests/framework/artifacts.py
Original file line number Diff line number Diff line change
Expand Up @@ -123,16 +123,13 @@ def firecracker_artifacts():
cargo_version = get_firecracker_version_from_toml()
# until the next minor version (but *not* including)
max_version = (cargo_version.major, cargo_version.minor + 1, 0)
min_version = (1, 3, 0)
prefix = "firecracker/firecracker-*"
for firecracker in sorted(ARTIFACT_DIR.glob(prefix)):
match = re.match(r"firecracker-v(\d+)\.(\d+)\.(\d+)", firecracker.name)
if not match:
continue
fc = FirecrackerArtifact(firecracker)
version = fc.version_tuple
if version < min_version:
continue
if version >= max_version:
continue
yield pytest.param(fc, id=fc.name)
Expand Down

0 comments on commit c001c6a

Please sign in to comment.