Skip to content

Commit

Permalink
test(net): relax timeouts
Browse files Browse the repository at this point in the history
The main reason we have timeouts is so that we can get some useful
debugging information in case they do happen. This means the timesouts
only need to be strict enough to avoid running into the pytest timeout
instead. 10s/1s however still gets us spurious failures, since in the
non-performance tests contention on host networking resources (we use a
TON of networking namespaces) is pretty bad. So increase the timeouts to
something that still allows us to not run into the pytest timeout, while
hopefully returning spurious failures once and for all.

Signed-off-by: Patrick Roy <[email protected]>
  • Loading branch information
roypat committed Oct 22, 2024
1 parent 90ac878 commit c97418a
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion tests/host_tools/network.py
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ def _init_connection(self):
We'll keep trying to execute a remote command that can't fail
(`/bin/true`), until we get a successful (0) exit code.
"""
self.check_output("true", timeout=10, debug=True)
self.check_output("true", timeout=100, debug=True)

def run(self, cmd_string, timeout=None, *, check=False, debug=False):
"""
Expand Down

0 comments on commit c97418a

Please sign in to comment.