Skip to content

Commit

Permalink
Merge branch 'main' into clippy_cast_lossless
Browse files Browse the repository at this point in the history
  • Loading branch information
Jonathan Woollett-Light authored Nov 7, 2022
2 parents 5307637 + 4f853c8 commit cc53056
Show file tree
Hide file tree
Showing 2 changed files with 14 additions and 4 deletions.
2 changes: 1 addition & 1 deletion docs/devctr-image.md
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ registry. The Firecracker CI suite must also be updated to use the new image.

```bash
docker login --username AWS --password \
$(aws ecr-public get-login-password) public.ecr.aws
$(aws ecr-public get-login-password --region us-east-1) public.ecr.aws
```

1. Navigate to the Firecracker directory. Verify that you have the latest
Expand Down
16 changes: 13 additions & 3 deletions docs/getting-started.md
Original file line number Diff line number Diff line change
Expand Up @@ -314,6 +314,17 @@ arguments is available via:
tools/devtool --help
```

### Alternative: Building Firecracker without devtool

It is possible to build Firecracker without invoking `devtool` by instead
running `cargo build`. However, binaries generated like this should not
be used in production and are considered experimental.

Note that the default target for Firecracker is `x86_64-unknown-linux-musl`
(set in `.cargo/config`). If you want to build an ARM binary, you need to
pass `--target aarch64-unknown-linux-musl` to `cargo build`, even if
compiling on an ARM machine. Otherwise it will try to build an `x86_64` binary.

### Alternative: Building Firecracker using glibc

The toolchain that Firecracker is tested against and that is recommended for
Expand All @@ -331,9 +342,8 @@ arch=`uname -m`
cargo build --target ${arch}-unknown-linux-gnu
```

That being said, Firecracker binaries linked with glibc or built without
`devtool` are always considered experimental and should not be used in
production.
That being said, Firecracker binaries linked with glibc are always considered
experimental and should not be used in production.

## Running the Integration Test Suite

Expand Down

0 comments on commit cc53056

Please sign in to comment.