Microvm helpers for interactive usage #4081
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pb8o
added
Status: Awaiting author
Codecov ReportPatch coverage has no change and project coverage change:
Additional details and impacted files@@ Coverage Diff @@
## main #4081 +/- ##
==========================================
- Coverage 82.26% 82.24% -0.03%
==========================================
Files 225 225
Lines 28466 28466
==========================================
- Hits 23417 23411 -6
- Misses 5049 5055 +6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
added
Status: Awaiting review
|
Reopening as it was closed by mistake |
wearyzen
force-pushed
the
vm-helpers
branch
from
0eff96b to
a0ddb07
Compare
wearyzen
previously approved these changes
Sep 15, 2023
bchalios
reviewed
Sep 15, 2023
Actually I had some docs written for a different change, but they belong here. I will update the PR. |
wearyzen
previously approved these changes
Sep 15, 2023
wearyzen
reviewed
Sep 15, 2023
pb8o
force-pushed
the
vm-helpers
branch
3 times, most recently
from
7321629 to
cf67f5a
Compare
We should run the `build_devctr` target to test the Dockerfile changes. In addition, also test the release if we make any changes to it. Signed-off-by: Pablo Barbáchano <[email protected]>
Some utility functions to help when interactively debugging tests, including one to run gdb on the microvm. Signed-off-by: Pablo Barbáchano <[email protected]>
If the process has disappeared before we can reach it, ignore the failure when measuring memory. Signed-off-by: Pablo Barbáchano <[email protected]>
bchalios
approved these changes
Sep 20, 2023
wearyzen
reviewed
Sep 20, 2023
wearyzen
approved these changes
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Some unrelated changes included:
Reason
This enables interactive use of Microvms, will follow up with a sandbox helper script.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.