Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: Update fingerprint files #4104

Merged
merged 1 commit into from
Sep 14, 2023
Merged

Conversation

zulinx86
Copy link
Contributor

@zulinx86 zulinx86 commented Sep 12, 2023

Changes / Reason

Since kernel and microcode updates changed the guest CPU config, update the fingerprint files.

Changes on guest CPU config are as follows:

  • CPUID.0x7:EBX
    • ERMS (bit 9) on AMD (marked as reserved in APM)
  • CPUID.0x7:EDX
    • FSRM (bit 4) on AMD + kernel 5.10 and 6.10 (marked as reserved in APM)
  • IA32_ARCH_CAPABILITIES MSR (index: 0x10A)
    • GDS_CTRL (bit 25) on Intel + kernel 4.14
    • GDS_NO (bit 26) on Intel
  • kvm_capabilities and vcpu_features fields were added in PR Addition of kvm_capabilities and vcpu_features to custom CPU templates #3967.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • [ ] If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • [ ] Any required documentation changes (code and docs) are included in this PR.
  • [ ] API changes follow the Runbook for Firecracker API changes.
  • [ ] User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • [ ] New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@codecov
Copy link

codecov bot commented Sep 12, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (24e2e29) 82.35% compared to head (1bdb6bc) 82.35%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4104   +/-   ##
=======================================
  Coverage   82.35%   82.35%           
=======================================
  Files         225      225           
  Lines       28469    28469           
=======================================
  Hits        23447    23447           
  Misses       5022     5022           
Flag Coverage Δ
4.14-c7g.metal 77.78% <ø> (ø)
4.14-m5d.metal 79.66% <ø> (-0.02%) ⬇️
4.14-m6a.metal 78.78% <ø> (ø)
4.14-m6g.metal 77.78% <ø> (ø)
4.14-m6i.metal 79.65% <ø> (ø)
5.10-c7g.metal 80.69% <ø> (ø)
5.10-m5d.metal 82.34% <ø> (+0.01%) ⬆️
5.10-m6a.metal 81.55% <ø> (ø)
5.10-m6g.metal 80.69% <ø> (ø)
5.10-m6i.metal 82.33% <ø> (ø)
6.1-c7g.metal 80.69% <ø> (ø)
6.1-m5d.metal 82.34% <ø> (ø)
6.1-m6a.metal 81.55% <ø> (ø)
6.1-m6g.metal 80.69% <ø> (ø)
6.1-m6i.metal 82.33% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@zulinx86 zulinx86 self-assigned this Sep 13, 2023
@zulinx86 zulinx86 marked this pull request as ready for review September 13, 2023 12:37
@zulinx86 zulinx86 added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Sep 13, 2023
Changes on guest CPU config are as follows:
- CPUID.0x7:EBX
  - ERMS (bit 9) on AMD (marked as reserved in APM)
- CPUID.0x7:EDX
  - FSRM (bit 4) on AMD + kernel 5.10 and 6.10 (marked as reserved in
    APM)
- IA32_ARCH_CAPABILITIES MSR (index: 0x10A)
  - GDS_CTRL (bit 25) on Intel + kernel 4.14
  - GDS_NO (bit 26) on Intel

kvm_capabilities and vcpu_features fields were added in PR firecracker-microvm#3967.

Signed-off-by: Takahiro Itazuri <[email protected]>
@wearyzen wearyzen merged commit d6b309a into firecracker-microvm:main Sep 14, 2023
@zulinx86 zulinx86 deleted the fp_update branch September 14, 2023 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants