vmm: Remove PC from vCPU config dump #4118
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zulinx86
force-pushed
the
remove_pc_from_fp
branch
2 times, most recently
from
bde8d4e to
4a0a44e
Compare
zulinx86
requested review from
xmarcalx,
kalyazin,
pb8o and
wearyzen
as code owners
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #4118 +/- ##
=======================================
Coverage 82.28% 82.29%
=======================================
Files 225 225
Lines 28457 28470 +13
=======================================
+ Hits 23416 23429 +13
Misses 5041 5041
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
zulinx86
force-pushed
the
remove_pc_from_fp
branch
from
4a0a44e to
a8deede
Compare
4 tasks
zulinx86
force-pushed
the
remove_pc_from_fp
branch
4 times, most recently
from
df99d07 to
cdb88f8
Compare
The dumped vCPU config is used to: - create a new custom CPU template based on it - keep track of its changes over time. The value of program counter (PC) is determined by the given kernel image, so it should not be overwritten by a custom CPU template and does not need to be tracked as part of a fingerprint file. Signed-off-by: Takahiro Itazuri <[email protected]>
The /proc/cpuinfo shows what the lscpu command shows and the microcode version. Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
force-pushed
the
remove_pc_from_fp
branch
from
cdb88f8 to
3856b58
Compare
zulinx86
added
the
Status: Awaiting review
kalyazin
approved these changes
Sep 21, 2023
roypat
approved these changes
Sep 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Reason
The dumped vCPU config is used to:
The value of program counter (PC) is determined by the given kernel image, so it should not be overwritten by a custom CPU template and does not need to be tracked as part of a fingerprint file.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.CHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.