Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add sandbox tool #4128

Merged
merged 5 commits into from
Sep 27, 2023
Merged

Add sandbox tool #4128

merged 5 commits into from
Sep 27, 2023

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Sep 22, 2023

Changes

Add a sandbox tool, useful for quick experiments and developing tests.

Reason

Productivity

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Status: Awaiting author Indicates that an issue or pull request requires author action python Pull requests that update Python code labels Sep 22, 2023
@pb8o pb8o requested a review from xmarcalx as a code owner September 22, 2023 15:26
@pb8o pb8o self-assigned this Sep 22, 2023
@codecov
Copy link

codecov bot commented Sep 22, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6600000) 83.12% compared to head (180e9f2) 83.12%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4128   +/-   ##
=======================================
  Coverage   83.12%   83.12%           
=======================================
  Files         225      225           
  Lines       28581    28581           
=======================================
  Hits        23758    23758           
  Misses       4823     4823           
Flag Coverage Δ
4.14-c7g.metal 78.68% <ø> (+<0.01%) ⬆️
4.14-m5d.metal 80.47% <ø> (ø)
4.14-m6a.metal 79.62% <ø> (ø)
4.14-m6g.metal 78.68% <ø> (ø)
4.14-m6i.metal 80.46% <ø> (ø)
5.10-c7g.metal 81.58% <ø> (ø)
5.10-m5d.metal 83.14% <ø> (ø)
5.10-m6a.metal 82.38% <ø> (ø)
5.10-m6g.metal 81.58% <ø> (ø)
5.10-m6i.metal 83.12% <ø> (ø)
6.1-c7g.metal 81.58% <ø> (+<0.01%) ⬆️
6.1-m5d.metal 83.13% <ø> (ø)
6.1-m6a.metal 82.38% <ø> (ø)
6.1-m6g.metal 81.58% <ø> (ø)
6.1-m6i.metal 83.12% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pb8o pb8o force-pushed the add-sandbox branch 6 times, most recently from ba5a7ee to 10dccb0 Compare September 25, 2023 13:44
@zulinx86 zulinx86 self-requested a review September 26, 2023 14:30
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Sep 26, 2023
Since Kani can take ~25min to complete, we can skip it if there has been
no changes in the Rust codebase.

Signed-off-by: Pablo Barbáchano <[email protected]>
Previous commit was missing part of the method.

Signed-off-by: Pablo Barbáchano <[email protected]>
Also add the missing iptables dependency

Signed-off-by: Pablo Barbáchano <[email protected]>
Add a sandbox tool to run experiments and to do quick checks.

Signed-off-by: Pablo Barbáchano <[email protected]>
@zulinx86 zulinx86 merged commit 2557b17 into firecracker-microvm:main Sep 27, 2023
5 checks passed
@pb8o pb8o deleted the add-sandbox branch October 19, 2023 14:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants