test: Skip kani if not enough RAM #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4136 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 225 225
Lines 28605 28605
=======================================
Hits 23772 23772
Misses 4833 4833
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
no-local-kani
branch
from
117d0f5 to
3c9d8cd
Compare
roypat
force-pushed
the
no-local-kani
branch
from
3c9d8cd to
24c8127
Compare
roypat
changed the title
roypat
force-pushed
the
no-local-kani
branch
from
24c8127 to
4eb26b9
Compare
roypat
added
the
Status: Awaiting review
bchalios
requested changes
Sep 27, 2023
roypat
force-pushed
the
no-local-kani
branch
2 times, most recently
from
b58cbbd to
af498db
Compare
JonathanWoollett-Light
previously approved these changes
Sep 28, 2023
Trying to run the kani integration test outside of the CI will almost certainly result in out of memory conditions in the best case, and in system hangs in the worst case. Therefore, do not attempt to run kani if running tests locally. Signed-off-by: Patrick Roy <[email protected]>
Currently, we only run kani if a .rs file is modified. We should also run it if dependencies are changed. Signed-off-by: Patrick Roy <[email protected]>
pb8o
approved these changes
Oct 6, 2023
bchalios
approved these changes
Oct 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trying to run the kani integration test outside of the CI will almost certainly result in out of memory conditions in the best case, and in system hangs in the worst case. Therefore, do not attempt to run kani if running tests locally.
Also removes an unneeded assertion, as
run_cmdalready checks the exit code by default.License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.