Final A/B-Tests #4139
Merged
Final A/B-Tests #4139
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4139 +/- ##
=======================================
Coverage 83.10% 83.10%
=======================================
Files 225 225
Lines 28604 28604
=======================================
Hits 23771 23771
Misses 4833 4833
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
roypat
force-pushed
the
most-ab
branch
4 times, most recently
from
138d51c to
faa15d2
Compare
roypat
force-pushed
the
most-ab
branch
3 times, most recently
from
b809012 to
4e6ec9f
Compare
zulinx86
previously approved these changes
Sep 29, 2023
roypat
force-pushed
the
most-ab
branch
2 times, most recently
from
766a491 to
af2fdc4
Compare
Similar to the snapshot, network latency and block tests, our vsock throughput test adapted to work with A/B-testing. Signed-off-by: Patrick Roy <[email protected]>
Converts the existing network tcp throughput test into an A/B-compatible TCP throughput test. This test is added to test_network_ab.py, since the converted test is short enough that we can collect all the network related tests in a single file. Signed-off-by: Patrick Roy <[email protected]>
Without this information, it is impossible to tell apart p-values for different metrics emitted from the same test. Signed-off-by: Patrick Roy <[email protected]>
Otherwise, the reemitted metrics will carry a namespace of "local", which does not make much sense inside of Cloudwatch. Signed-off-by: Patrick Roy <[email protected]>
Before emitting raw data, we only submitted the average to display on our dashboards. However, ever since submitting the raw data, we could have just instructed cloudwatch to compute averages from that, without needing to also submit the averages. So actually switch to doing that. Also rename network_ab's "latency" metric to "ping_latency" for backward compatibility. Signed-off-by: Patrick Roy <[email protected]>
Because its a waste of comptue resources to run it if only markdown files were changed. Signed-off-by: Patrick Roy <[email protected]>
We want to call the one in host_tools.metrics so that the properties are correctly set. Signed-off-by: Patrick Roy <[email protected]>
The raw time series emitted from iperf3 include data points from the warmup period. Since we do our A/B-Test on this entire time series, we should exclude them. Signed-off-by: Patrick Roy <[email protected]>
roypat
added
the
Status: Awaiting review
pb8o
approved these changes
Oct 2, 2023
zulinx86
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Adds A/B compatible versions of the vsock and tcp throughput tests. Also includes the following small refractorings/improvements:
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.