Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support AL2023 officially #4151

Merged
merged 4 commits into from
Oct 6, 2023
Merged

Support AL2023 officially #4151

merged 4 commits into from
Oct 6, 2023

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Oct 5, 2023

Changes

  • Note in the changelog that we officially support Linux 6.1 kernel.
  • Document how to deal with performance regressions in Linux 6.1.
  • Enforce the boot time SLA of 150ms in 6.1 back (reverts 1c0b992)

Closes #3837

Reason

To keep up to date with stable Linux kernel releases.

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Until now, kernel version has been enough to disambiguate the OS, but by
being explicit we can disambiguate in the case we have distinct OSes
with the same kernel.

Signed-off-by: Pablo Barbáchano <[email protected]>
@pb8o pb8o self-assigned this Oct 5, 2023
@pb8o pb8o added Type: Documentation Indicates a need for improvements or additions to documentation Status: Awaiting author Indicates that an issue or pull request requires author action labels Oct 5, 2023
@pb8o pb8o force-pushed the al2023 branch 3 times, most recently from 17d777b to f7d2ec2 Compare October 5, 2023 12:30
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (2bc525b) 83.10% compared to head (0ca4e93) 83.10%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4151   +/-   ##
=======================================
  Coverage   83.10%   83.10%           
=======================================
  Files         225      225           
  Lines       28605    28605           
=======================================
  Hits        23772    23772           
  Misses       4833     4833           
Flag Coverage Δ
4.14-c7g.metal 78.67% <ø> (+<0.01%) ⬆️
4.14-m5d.metal 80.47% <ø> (ø)
4.14-m6a.metal 79.61% <ø> (ø)
4.14-m6g.metal 78.67% <ø> (ø)
4.14-m6i.metal 80.45% <ø> (ø)
5.10-c7g.metal 81.57% <ø> (ø)
5.10-m5d.metal 83.13% <ø> (ø)
5.10-m6a.metal 82.37% <ø> (ø)
5.10-m6g.metal 81.57% <ø> (ø)
5.10-m6i.metal 83.11% <ø> (ø)
6.1-c7g.metal 81.57% <ø> (ø)
6.1-m5d.metal 83.13% <ø> (ø)
6.1-m6a.metal 82.37% <ø> (ø)
6.1-m6g.metal 81.57% <ø> (ø)
6.1-m6i.metal 83.11% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

docs/prod-host-setup.md Outdated Show resolved Hide resolved
@pb8o pb8o requested a review from zulinx86 October 5, 2023 14:37
@pb8o pb8o added Status: Awaiting review Indicates that a pull request is ready to be reviewed Release Indicates that an issue or pull request is part of the next release Type: Performance Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled and removed Status: Awaiting author Indicates that an issue or pull request requires author action labels Oct 5, 2023
ShadowCurse
ShadowCurse previously approved these changes Oct 5, 2023
docs/prod-host-setup.md Outdated Show resolved Hide resolved
docs/prod-host-setup.md Outdated Show resolved Hide resolved
docs/prod-host-setup.md Outdated Show resolved Hide resolved
docs/prod-host-setup.md Outdated Show resolved Hide resolved
roypat
roypat previously approved these changes Oct 6, 2023
Copy link
Contributor

@roypat roypat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

docs/prod-host-setup.md Outdated Show resolved Hide resolved
pb8o and others added 2 commits October 6, 2023 10:16
Linux 6.1 brought a guest boottime performance regression. This commits
documents the issue in ./docs/prod-host-setup.md and uses the
mitigations to enforce our boot time SLA.

Signed-off-by: Pablo Barbáchano <[email protected]>
Co-authored-by: Luiz Capitulino <[email protected]>
Make the git information for metrics optional. Useful when running
outside of a classic git repository, for example extracted from a
tarball or a git worktree.

Signed-off-by: Pablo Barbáchano <[email protected]>
Copy link
Contributor

@xmarcalx xmarcalx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed docs and LGTM, thanks for the changes Pablo!

@roypat roypat merged commit 63395be into firecracker-microvm:main Oct 6, 2023
5 checks passed
@pb8o pb8o deleted the al2023 branch October 13, 2023 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: High Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Release Indicates that an issue or pull request is part of the next release Status: Awaiting review Indicates that a pull request is ready to be reviewed Type: Documentation Indicates a need for improvements or additions to documentation Type: Performance
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Support 5.15 and 6.1 LTS kernels
5 participants