test: add a fixture for Qemu vhost-user-blk backend #4156
Conversation
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4156 +/- ##
=======================================
Coverage 82.99% 82.99%
=======================================
Files 223 223
Lines 28448 28448
=======================================
Hits 23609 23609
Misses 4839 4839
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
The following is added: - gpg, gpg-agent - bison, flex - libglib2.0-dev - libpixman-1-dev - ninja-build - meson This increases the images size by ~30K. Signed-off-by: Nikita Kalyazin <[email protected]>
The new warnings are likely caused by the devctr update. Signed-off-by: Nikita Kalyazin <[email protected]>
The fixture fetches a Qemu release, verifies its signature, configures and builds the vhost-user-blk backend. The fixture is supposed to be used for testing vhost-user-blk device. Command line options: -s, --socket-path=PATH Use UNIX socket path -b, --blk-file=PATH block device or file path -r, --read-only Enable read-only Signed-off-by: Nikita Kalyazin <[email protected]>
kalyazin
added
the
Status: Awaiting review
| @@ -58,6 +59,11 @@ | |||
|
|
|||
|
|
|||
| METRICS = get_metrics_logger() | |||
| QEMU_PUB_KEY_URL = "https://keys.openpgp.org/vks/v1/by-fingerprint/CEACC9E15534EBABB82D3FA03353C9CEF108B584" | |||
There was a problem hiding this comment.
The Ubuntu packages don't have the vhost-user-blk binary?
There was a problem hiding this comment.
that was my first guess too, but I wasn't able to find it.
|
Why can't we just add a pre-compiled qemu vhost backend to the devctr instead of downloading/compiling it on the fly? |
I was also thinking about it. I think it depends on the upgrade pace. If we need to update it often, having it as a constant in the test is easier (doesn't involve building an image). We don't know this in advance, unfortunately, so I'm open to change if we have enough data. |
|
Decided to move the backend build to devctr build time. Implemented in #4167 . |
Changes
This adds a fixture for Qemu's vhost-user-blk backend. The fixture fetches a Qemu release (currently v8.1.1) and builds the backend binary.
The build requires additional dependencies in the devctr image (increases by ~30K).
The backend can be used as:
Reason
Needed for integration tests for vhsot-user-blk device.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in this PR.[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.rust-vmm.