Forward-Port 1.5 branch hot-fixes + correctly bump snapshot version for 1.6 #4169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Was forgotten to be added before. Signed-off-by: Patrick Roy <[email protected]>
File is only for humans, sorry. Signed-off-by: Patrick Roy <[email protected]>
So I don't have to wait over an hour to see if it worked or not. Also remove a `touch build.rs` that was leftover from when we needed the buildscript to determine the firecracker version. Signed-off-by: Patrick Roy <[email protected]>
In the pre-release testing environment everything seems slower, and it keeps failing with hitting this timeout. Signed-off-by: Patrick Roy <[email protected]>
It is flaky due to concurrent microVMs holding networking locks in the kernel, causing delays on net device attachments. Signed-off-by: Patrick Roy <[email protected]>
It seems a rebase gone awry caused the version bump from firecracker-microvm#3557 to be considered as part of 1.5, even though it will only land with 1.6. Swap the two lines to unblock CI. Signed-off-by: Patrick Roy <[email protected]>
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4169 +/- ##
=======================================
Coverage 82.98% 82.98%
=======================================
Files 223 223
Lines 28508 28508
=======================================
Hits 23656 23656
Misses 4852 4852
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
pb8o
previously approved these changes
Oct 12, 2023
JonathanWoollett-Light
previously approved these changes
Oct 12, 2023
kalyazin
previously approved these changes
Oct 12, 2023
Didnt happen as part of post-relase preparation because it was not listed as an artifact then. Signed-off-by: Patrick Roy <[email protected]>
Move unreleased thigns to [1.5.0], because we released 1.5.0 Signed-off-by: Patrick Roy <[email protected]>
roypat
dismissed stale reviews from kalyazin and JonathanWoollett-Light
via
e3a3c41
roypat
force-pushed
the
forward-ports-plus-fix
branch
from
8bf817e to
e3a3c41
Compare
kalyazin
approved these changes
Oct 12, 2023
JonathanWoollett-Light
approved these changes
Oct 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems a rebase gone awry caused the version bump from #3557 to be
considered as part of 1.5, even though it will only land with 1.6. Swap
the two lines to unblock CI.
Also includes some commits from the 1.5 branch
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following
Developer Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
CHANGELOG.md.TODOs link to an issue.rust-vmm.