[tests] Network and cpu utilization improvements #4456
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #4456 +/- ##
=======================================
Coverage 81.63% 81.63%
=======================================
Files 243 243
Lines 29789 29789
=======================================
Hits 24319 24319
Misses 5470 5470
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
4 times, most recently
from
b57909e to
4fe11bf
Compare
ShadowCurse
added
the
Status: Awaiting review
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
from
4fe11bf to
587c992
Compare
roypat
reviewed
Feb 19, 2024
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
3 times, most recently
from
27e4a36 to
166a938
Compare
roypat
previously approved these changes
Feb 20, 2024
bchalios
reviewed
Feb 20, 2024
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
2 times, most recently
from
13d9a6a to
38614b6
Compare
roypat
previously approved these changes
Feb 20, 2024
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
from
38614b6 to
717d953
Compare
roypat
approved these changes
Feb 20, 2024
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
from
717d953 to
a20c25f
Compare
Fix style in the test_dependencies.py Signed-off-by: Egor Lazarchuk <[email protected]>
The additional iterations for the ping test were introduced in order to decrease false positive rate of the A/B tests. With automatic retries of A/B tests these additional iterations are not needed anymore. Signed-off-by: Egor Lazarchuk <[email protected]>
Move GUEST_MEM_MIB and GUEST_VCPUS into network_microvm fixture. GUEST_VCPUS was not used anywere. GUEST_MEM_MIB was only used in the fixture itself. Signed-off-by: Egor Lazarchuk <[email protected]>
Move test specific global variables into the test they are used in. This way all test related info is inside the test itself. Signed-off-by: Egor Lazarchuk <[email protected]>
Remove TcpIPerf3Test class as it is only used in one test and only contains some parameters for inner class. Signed-off-by: Egor Lazarchuk <[email protected]>
These vars were not used anywhere. Signed-off-by: Egor Lazarchuk <[email protected]>
Replace mappings of iperf3 modes with iperf3 flags with separate methods. This simplifies the process of getting correct mode/flag for specific client. Signed-off-by: Egor Lazarchuk <[email protected]>
Remove SERVER_STARTUP_TIME_SEC as it is only used in one function. Use the values directly instead. Signed-off-by: Egor Lazarchuk <[email protected]>
Remove classes/methods not used anywhere in the codebase. Signed-off-by: Egor Lazarchuk <[email protected]>
Cpu utilization was gathered per thread name per thread PID. But
thread PID or name never changes, so tracking per thread name is
enough.
Previous data format:
```
{
"thread_name": {
"thread_pid": util,
}
}
```
New data format:
```
{
"thread_name": util,
}
```
Also renamed get_cpu_percent in 2 places to get_cpu_utilization and
track_cpu_utilization to have a better separation.
Signed-off-by: Egor Lazarchuk <[email protected]>
Add metrics for all fc threads cpu utilization. Signed-off-by: Egor Lazarchuk <[email protected]>
ProcessManager had only static methods. Removing it simplifies the code a bit. Signed-off-by: Egor Lazarchuk <[email protected]>
We don't want to test cpu utilization in a/b test. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
net_perf_upgrades
branch
from
a20c25f to
a75a2ac
Compare
bchalios
approved these changes
Feb 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Minor clean up of network and cpu utilization testing code.
Now cpu utilization is tracked for all threads.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
PR.
CHANGELOG.md.TODOs link to an issue.contribution quality standards.
rust-vmm.