Backport fixes to v1.6 #4463
Merged
Backport fixes to v1.6 #4463
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[ Upstream commit a823911 ] There is a REPTAR exception reported on m6i.metal for guest kernel versions 4.14/5.10/6.1 when spectre-meltdown-checker.sh script is run inside the guest from below the tests: test_spectre_meltdown_checker_on_guest and test_spectre_meltdown_checker_on_restored_guest The same script when run on host doesn't report the exception which means the instances are actually not vulnerable to REPTAR. The only reason why the script cannot determine if the guest is vulnerable or not is because Firecracker does not expose the microcode version to the guest. The check is check_CVE_2023_23583_linux in spectre-meltdown-checker.sh Since we have a test on host and the exception in guest is not valid, we add a check to ignore this exception. There could be more such exceptions added to check_vulnerabilities_on_guest() in the future but generalising this function based on instance kernel versions etc. without more data looked like overkill right now so, the function handles the exception only for REPTAR and m6i. Signed-off-by: Sudan Landge <[email protected]> Signed-off-by: Takahiro Itazuri <[email protected]>
zulinx86
added
the
Status: Awaiting review
ShadowCurse
previously approved these changes
Feb 19, 2024
pb8o
previously approved these changes
Feb 19, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## firecracker-v1.6 #4463 +/- ##
=================================================
Coverage 81.55% 81.55%
=================================================
Files 240 240
Lines 29367 29367
=================================================
Hits 23951 23951
Misses 5416 5416
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
zulinx86
changed the title
[ Upstream commit 8bb8831 ] Without `--locked` option, installing cargo tools may fail for some reasons. `--locked` option is useful for reproducible installation since it ensures to use the exact same set of dependencies. Signed-off-by: Takahiro Itazuri <[email protected]>
wearyzen
approved these changes
Feb 19, 2024
pb8o
approved these changes
Feb 19, 2024
zulinx86
merged commit 094f066
into
firecracker-microvm:firecracker-v1.6
6 of 7 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Backport the following commits to v1.6:
Reason
To make the nightly PR test pass on v1.6 branch.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
[ ] If a specific issue led to this PR, this PR closes the issue.[ ] Any required documentation changes (code and docs) are included in thisPR.
[ ] API changes follow the Runbook for Firecracker API changes.[ ] User-facing changes are mentioned inCHANGELOG.md.[ ] NewTODOs link to an issue.contribution quality standards.
rust-vmm.