Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deserializing the json body of a request: trailing comma in example #4873

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stvnwrgs
Copy link

Changes

  • Fix typo with ","
    ...

Reason

Example failes
...

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • If a specific issue led to this PR, this PR closes the issue.
  • The description of changes is clear and encompassing.
  • Any required documentation changes (code and docs) are included in this
    PR.
  • API changes follow the Runbook for Firecracker API changes.
  • User-facing changes are mentioned in CHANGELOG.md.
  • All added/changed functionality is tested.
  • New TODOs link to an issue.
  • Commits meet
    contribution quality standards.

  • This functionality cannot be added in rust-vmm.

Copy link
Contributor

@Manciukic Manciukic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Could you just fix the commit message to include the sign-off line?
https://github.com/firecracker-microvm/firecracker/pull/4873/checks?check_run_id=32062147263

Also, a commit body is required to pass the CI checks. You can run those locally with the devtool

tools/devtool test -- integration_tests/style

@pb8o
Copy link
Contributor

pb8o commented Nov 7, 2024

Hi @stvnwrgs , I see our style checks didn't pass. You just need to add some text to the commit body. If you want to run our style checks on your end, you can do it by running ./tools/devtool checkstyle.

@xmarcalx
Copy link
Contributor

Hi @stvnwrgs,

We hope to find you well and thanks again for the contribution.
Are you still interested into bringing this change to the finish line? ^^

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants