Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: flesh out the AMD Genoa host vs guest test #4947

Merged
merged 1 commit into from
Dec 10, 2024

Conversation

pb8o
Copy link
Contributor

@pb8o pb8o commented Dec 6, 2024

Changes

Record the differences with AMD Milan CPU.

Reason

License Acceptance

By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.

PR Checklist

  • I have read and understand CONTRIBUTING.md.
  • I have run tools/devtool checkstyle to verify that the PR passes the
    automated style checks.
  • I have described what is done in these changes, why they are needed, and
    how they are solving the problem in a clear and encompassing way.
  • I have updated any relevant documentation (both in code and in the docs)
    in the PR.
  • I have mentioned all user-facing changes in CHANGELOG.md.
  • If a specific issue led to this PR, this PR closes the issue.
  • When making API changes, I have followed the
    Runbook for Firecracker API changes.
  • I have tested all new and changed functionalities in unit tests and/or
    integration tests.
  • I have linked an issue to every new TODO.

  • This functionality cannot be added in rust-vmm.

@pb8o pb8o added Type: Bug Indicates an unexpected problem or unintended behavior Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled Status: Awaiting author Indicates that an issue or pull request requires author action python Pull requests that update Python code labels Dec 6, 2024
@pb8o pb8o self-assigned this Dec 6, 2024
Manciukic
Manciukic previously approved these changes Dec 6, 2024
Copy link

codecov bot commented Dec 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 84.07%. Comparing base (db2e270) to head (067c723).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4947   +/-   ##
=======================================
  Coverage   84.07%   84.07%           
=======================================
  Files         251      251           
  Lines       28059    28059           
=======================================
  Hits        23592    23592           
  Misses       4467     4467           
Flag Coverage Δ
5.10-c5n.metal 84.65% <ø> (+<0.01%) ⬆️
5.10-m5n.metal 84.63% <ø> (+<0.01%) ⬆️
5.10-m6a.metal 83.94% <ø> (ø)
5.10-m6g.metal 80.74% <ø> (ø)
5.10-m6i.metal 84.62% <ø> (ø)
5.10-m7g.metal 80.74% <ø> (ø)
6.1-c5n.metal 84.65% <ø> (ø)
6.1-m5n.metal 84.63% <ø> (+<0.01%) ⬆️
6.1-m6a.metal 83.93% <ø> (ø)
6.1-m6g.metal 80.74% <ø> (-0.01%) ⬇️
6.1-m6i.metal 84.62% <ø> (ø)
6.1-m7g.metal 80.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

roypat
roypat previously approved these changes Dec 6, 2024
@pb8o pb8o dismissed stale reviews from roypat and Manciukic via 21f7ed9 December 6, 2024 12:55
@pb8o pb8o force-pushed the fix-test-genoa branch 2 times, most recently from 21f7ed9 to b9b6742 Compare December 6, 2024 12:55
Manciukic
Manciukic previously approved these changes Dec 6, 2024
JackThomson2
JackThomson2 previously approved these changes Dec 6, 2024
@pb8o pb8o dismissed stale reviews from JackThomson2 and Manciukic via 6ff54a7 December 6, 2024 14:28
@pb8o pb8o force-pushed the fix-test-genoa branch 6 times, most recently from bbd99db to 03d822d Compare December 6, 2024 18:02
@pb8o pb8o added the Status: Awaiting review Indicates that a pull request is ready to be reviewed label Dec 6, 2024
@pb8o pb8o removed the Status: Awaiting author Indicates that an issue or pull request requires author action label Dec 6, 2024
@pb8o pb8o changed the title fix(tests): bring back the AMD Genoa check fix(tests): flesh out the AMD Genoa host vs guest test Dec 6, 2024
@pb8o pb8o removed the Type: Bug Indicates an unexpected problem or unintended behavior label Dec 10, 2024
@pb8o pb8o changed the title fix(tests): flesh out the AMD Genoa host vs guest test tests: flesh out the AMD Genoa host vs guest test Dec 10, 2024
Record the differences wrt AMD Milan CPUs.

Signed-off-by: Pablo Barbáchano <[email protected]>
@roypat roypat merged commit 3b5f161 into firecracker-microvm:main Dec 10, 2024
7 checks passed
@pb8o pb8o deleted the fix-test-genoa branch December 10, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Priority: Medium Indicates than an issue or pull request should be resolved ahead of issues or pull requests labelled python Pull requests that update Python code Status: Awaiting review Indicates that a pull request is ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants